[Home]

Summary:ASTERISK-16784: [patch] Message lost when sox fails to re-encode with 'volgain'
Reporter:Sébastien Couture (sysreq)Labels:
Date Opened:2010-10-08 10:28:46Date Closed:2011-05-04 11:17:19
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue18111_1.4.patch
( 1) issue18111_1.6.2.patch
( 2) issue18111_1.8.patch
( 3) issue18111_trunk.patch
Description:When general or per-mailbox 'volgain' variable is set, sox is used to adjust the volume of (re-encode) a message. I've had cases where for some unknown reason, sox would fail re-encoding the wav file, and I'd be left _only_ with the message's temporary copy.. no trace of the msg000X.wav.

The message's description file (msg000X.txt) is not lost in the process, so the user's phone is notified that he/she has a new message through MWI, but is then unable to listen to it or even erase it.

We started experiencing that problem since we updated from 1.6.2.10 to 1.6.2.13.

****** ADDITIONAL INFORMATION ******

WARNING[1108] app_voicemail.c: Sox failed to re-encode /var/spool/asterisk/voicemail/default/101/INBOX/msg0004.wav: An error occurred during file processing (have you installed support for all sox file formats?)

In that case, there's no trace of /var/spool/asterisk/voicemail/default/101/INBOX/msg0004.wav after sox's failure to re-encode it.

Note: I do have support for all sox file formats installed, that issue usually arises one out of 200 messages left in mailboxes.
Comments:By: Chris Gentle (gentlec) 2010-11-01 14:15:31

I'm seeing this behavior with 1.8.0 also.
By: Sean Bright (seanbright) 2011-01-26 09:11:56.000-0600

I've uploaded patches for all supported versions of asterisk.  Please test the appropriate one for your version and report results.  You should still see the message about an error occurring, but the original file should be left intact.

By: Digium Subversion (svnbot) 2011-05-04 11:08:52

Repository: asterisk
Revision: 316707

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r316707 | seanbright | 2011-05-04 11:08:51 -0500 (Wed, 04 May 2011) | 8 lines

If sox fails when processing a voicemail, don't delete the original file.

(closes issue ASTERISK-16784)
Reported by: sysreq
Patches:
     issue18111_trunk.patch uploaded by seanbright (license 71)
Tested by: seanbright

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=316707
By: Digium Subversion (svnbot) 2011-05-04 11:11:01

Repository: asterisk
Revision: 316708

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_voicemail.c

------------------------------------------------------------------------
r316708 | seanbright | 2011-05-04 11:11:00 -0500 (Wed, 04 May 2011) | 15 lines

Merged revisions 316707 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r316707 | seanbright | 2011-05-04 12:08:50 -0400 (Wed, 04 May 2011) | 8 lines
 
 If sox fails when processing a voicemail, don't delete the original file.
 
 (closes issue ASTERISK-16784)
 Reported by: sysreq
 Patches:
       issue18111_trunk.patch uploaded by seanbright (license 71)
 Tested by: seanbright
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=316708
By: Digium Subversion (svnbot) 2011-05-04 11:15:34

Repository: asterisk
Revision: 316709

_U  branches/1.8/
U   branches/1.8/apps/app_voicemail.c

------------------------------------------------------------------------
r316709 | seanbright | 2011-05-04 11:15:34 -0500 (Wed, 04 May 2011) | 22 lines

Merged revisions 316708 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r316708 | seanbright | 2011-05-04 12:10:59 -0400 (Wed, 04 May 2011) | 15 lines
 
 Merged revisions 316707 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r316707 | seanbright | 2011-05-04 12:08:50 -0400 (Wed, 04 May 2011) | 8 lines
   
   If sox fails when processing a voicemail, don't delete the original file.
   
   (closes issue ASTERISK-16784)
   Reported by: sysreq
   Patches:
         issue18111_trunk.patch uploaded by seanbright (license 71)
   Tested by: seanbright
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=316709
By: Digium Subversion (svnbot) 2011-05-04 11:17:19

Repository: asterisk
Revision: 316711

_U  trunk/
U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r316711 | seanbright | 2011-05-04 11:17:18 -0500 (Wed, 04 May 2011) | 29 lines

Merged revisions 316709 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r316709 | seanbright | 2011-05-04 12:15:32 -0400 (Wed, 04 May 2011) | 22 lines
 
 Merged revisions 316708 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r316708 | seanbright | 2011-05-04 12:10:59 -0400 (Wed, 04 May 2011) | 15 lines
   
   Merged revisions 316707 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r316707 | seanbright | 2011-05-04 12:08:50 -0400 (Wed, 04 May 2011) | 8 lines
     
     If sox fails when processing a voicemail, don't delete the original file.
     
     (closes issue ASTERISK-16784)
     Reported by: sysreq
     Patches:
           issue18111_trunk.patch uploaded by seanbright (license 71)
     Tested by: seanbright
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=316711