Summary:	ASTERISK-16789: [patch] [regression] faxdetect now must apply to all dahdi channels; change from 1.6.2.x
Reporter:	Sean Darcy (seandarcy)	Labels:
Date Opened:	2010-10-11 14:34:38	Date Closed:	2010-10-13 15:24:53
Priority:	Blocker	Regression?	Yes
Status:	Closed/Complete	Components:	Applications/app_fax
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) issue18116_v1.8.patch
Description:	In 1.6.2.x you could place faxdetect = <whatever> anyplace before the channel you wanted it to apply to. Now it appears it must apply globally. ****** ADDITIONAL INFORMATION ****** In 1.6.2.x this worked: [trunkgroups] [channels] usecallerid=yes callwaiting=no usecallingpres=yes threewaycalling=yes transfer=yes canpark=yes cancallforward=yes callreturn=yes echocancel=yes echocancelwhenbridged=no echotraining=yes callgroup=0 pickupgroup=0 callprogress=yes progzone=us tonezone =0 ; 0 is US jbenable = no [home-phones] context=internal group=0 dahdichan => 1,2 [pstn] context=incoming-pstn-line faxdetect=incoming busydetect=yes group=1 dahdichan => 4   No longer. In 1.8 I need to place faxdetect above [home-phones]
Comments:	By: Richard Mudgett (rmudgett) 2010-10-12 16:04:36 Does it work for the first fax ONLY? The faxdetect option configuration processing code has not changed from 1.6.2.  However, I can see in the code where the faxdetect config option set on a channel is cleared when a fax is detected. By: Richard Mudgett (rmudgett) 2010-10-12 17:52:31 The issue18116_v1.8.patch should fix clearing the user set faxdetect config option. By: Digium Subversion (svnbot) 2010-10-13 15:21:05 Repository: asterisk Revision: 291541 U   branches/1.8/channels/chan_dahdi.c ------------------------------------------------------------------------ r291541 | rmudgett | 2010-10-13 15:21:04 -0500 (Wed, 13 Oct 2010) | 26 lines The chan_dahdi faxdetect option only works for the first FAX call. The chan_dahdi faxdetect option only works for the first call.  After that the option no longer works.  The struct dahdi_pvt.callprogress member is the encoded user config setting for the callprogress and faxdetect config options.  Changing this value alters the configuration for all following calls until the chan_dahdi.conf file is reloaded. * Fixed the chan_dahdi ast_channel_setoption callback to not change the users faxdetect config setting except for the current call. * Fixed the chan_dahdi ast_channel_queryoption callback to read the active DSP setting of the faxdetect option. * Made actually disable the active faxdetect DSP setting for the current call on the analog port.  my_handle_dtmfup() is used for normal analog ports.  dahdi_handle_dtmfup() is the legacy code and is no longer used unless in a radio mode. (closes issue ASTERISK-16789) Reported by: seandarcy Patches:      issue18116_v1.8.patch uploaded by rmudgett (license 664) Review: https://reviewboard.asterisk.org/r/972/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=291541 By: Digium Subversion (svnbot) 2010-10-13 15:24:53 Repository: asterisk Revision: 291542 _U  trunk/ U   trunk/channels/chan_dahdi.c ------------------------------------------------------------------------ r291542 | rmudgett | 2010-10-13 15:24:52 -0500 (Wed, 13 Oct 2010) | 33 lines Merged revisions 291541 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........  r291541 | rmudgett | 2010-10-13 15:21:02 -0500 (Wed, 13 Oct 2010) | 26 lines    The chan_dahdi faxdetect option only works for the first FAX call.    The chan_dahdi faxdetect option only works for the first call.  After that  the option no longer works.  The struct dahdi_pvt.callprogress member is  the encoded user config setting for the callprogress and faxdetect config  options.  Changing this value alters the configuration for all following  calls until the chan_dahdi.conf file is reloaded.    * Fixed the chan_dahdi ast_channel_setoption callback to not change the  users faxdetect config setting except for the current call.    * Fixed the chan_dahdi ast_channel_queryoption callback to read the active  DSP setting of the faxdetect option.    * Made actually disable the active faxdetect DSP setting for the current  call on the analog port.  my_handle_dtmfup() is used for normal analog  ports.  dahdi_handle_dtmfup() is the legacy code and is no longer used  unless in a radio mode.    (closes issue ASTERISK-16789)  Reported by: seandarcy  Patches:        issue18116_v1.8.patch uploaded by rmudgett (license 664)    Review: https://reviewboard.asterisk.org/r/972/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=291542