Summary: | ASTERISK-16795: [patch] Allow emailsubject and emailbody to be specified in voicemail.conf | ||
Reporter: | mdeneen (mdeneen) | Labels: | |
Date Opened: | 2010-10-12 12:35:46 | Date Closed: | 2011-08-23 23:45:17 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_voicemail |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) app_voicemail_emailsubject_emailbody_from_voicemail_conf.diff | |
Description: | In Asterisk 1.6.x, apply_options_full is only called if users.conf exists. That is, a mailbox defined in voicemail.conf can not set emailsubject or emailbody. ****** ADDITIONAL INFORMATION ****** I am not intimate with app_voicemail.c, so please verify that I have not added any sort of memory leak. I've verified that on a "voicemail reload" that the memory is ast_free'd, but there may be other interactions which I am not aware of. Please review | ||
Comments: | By: mdeneen (mdeneen) 2010-10-12 12:38:38 Sorry for the double patch in the summary. I didn't know that the bug tracker would prepend "patch" to the summary. By: mdeneen (mdeneen) 2010-10-25 12:31:11 Do I have to do anything to this? I received an email stating that Digium's legal team had accepted my license. By: mdeneen (mdeneen) 2011-02-22 10:07:57.000-0600 I'm a pretty patient guy, but several asterisk releases have been cut since last October. Is there any chance of this being included in a future release? By: Alec Davis (alecdavis) 2011-04-04 04:04:47 We'd been running 1.6.2 for ages, never had users.conf and had a custom email message, however we may have switched to 1.8.x before 1.6.2.11 Please further explain. By: mdeneen (mdeneen) 2011-04-04 09:22:38 Alec, Yes, you can have a custom email message in the [general] section. You can not, however, have a custom email message per vm defined in voicemail.conf without the patch. "emailsubject" and "emailbody" are only parsed in two places in app_voicemail.c. One is for the [general] section, and the other is called only if ucfg is not null. Hopefully this clears things up. By: Matt Jordan (mjordan) 2011-08-18 15:14:23.158-0500 This was actually worked in the previous iteration, but due to some JIRA-ness, didn't get turned on. The patch went into 1.8, and will be going into 10 and trunk. By: Matt Jordan (mjordan) 2011-08-18 15:15:24.852-0500 Note that this is similar to ASTERISK-16781; both issues will be fixed by the same patch. |