[Home]

Summary:ASTERISK-16800: [patch] stuck channels if followme context doesnt exists
Reporter:Clod Patry (junky)Labels:
Date Opened:2010-10-12 20:46:03Date Closed:2010-12-06 18:31:22.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_followme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) followme.diff
Description:If followme tried to call a non-existent context, the 2 local channels will be stucked.
You cant soft hangup those channels, you must restart *.
example without patch:
   -- Executing [11@junky:1] FollowMe("SIP/10-00000001", "junky") in new stack
   -- <SIP/10-00000001> Playing 'followme/pls-hold-while-try' (language 'en')
   -- Music class default requested but no musiconhold loaded.
   -- calling 10@doesntexist
[Oct 12 20:49:34] NOTICE[15253]: chan_local.c:511 local_call: No such extension/context 10@doesntexist while calling Local channel
   -- couldn't reach at this number.
 == Auto fallthrough, channel 'SIP/10-00000001' status is 'UNKNOWN'


The logic is just to check if the context is valid or not. If it not valid, it will return. This also prevents to create in memory, since we already know that chan_local.c will refuse it.


example with patch:
   -- Executing [11@junky:1] FollowMe("SIP/10-00000001", "junky") in new stack
   -- <SIP/10-00000001> Playing 'followme/pls-hold-while-try' (language 'en')
   -- Music class default requested but no musiconhold loaded.
[Oct 12 21:43:36] WARNING[20162]: app_followme.c:832 findmeexec: doesntexist doesnt exists, no need to continue...
   -- Executing [11@junky:2] Hangup("SIP/10-00000001", "") in new stack
 == Spawn extension (junky, 11, 2) exited non-zero on 'SIP/10-00000001'


****** ADDITIONAL INFORMATION ******

in extensions.conf:
exten => 11,1,FollowMe(junky);
exten => 11,n,Hangup();


in followme:
[junky]
context=doesntexist
number=10


I had a 1.4.30 with the same behavior.
Comments:By: Digium Subversion (svnbot) 2010-12-06 18:07:39.000-0600

Repository: asterisk
Revision: 297689

U   branches/1.4/apps/app_followme.c

------------------------------------------------------------------------
r297689 | tilghman | 2010-12-06 18:07:38 -0600 (Mon, 06 Dec 2010) | 8 lines

Don't create a Local channel if the target extension does not exist.

(closes issue ASTERISK-16800)
Reported by: junky
Patches:
      followme.diff uploaded by junky (license 177)
      (partially restructured by me to avoid a possible memory leak)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=297689
By: Digium Subversion (svnbot) 2010-12-06 18:21:51.000-0600

Repository: asterisk
Revision: 297713

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_followme.c

------------------------------------------------------------------------
r297713 | tilghman | 2010-12-06 18:21:51 -0600 (Mon, 06 Dec 2010) | 15 lines

Merged revisions 297689 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r297689 | tilghman | 2010-12-06 18:07:37 -0600 (Mon, 06 Dec 2010) | 8 lines
 
 Don't create a Local channel if the target extension does not exist.
 
 (closes issue ASTERISK-16800)
  Reported by: junky
  Patches:
        followme.diff uploaded by junky (license 177)
        (partially restructured by me to avoid a possible memory leak)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=297713
By: Digium Subversion (svnbot) 2010-12-06 18:29:27.000-0600

Repository: asterisk
Revision: 297733

_U  branches/1.8/
U   branches/1.8/apps/app_followme.c

------------------------------------------------------------------------
r297733 | tilghman | 2010-12-06 18:29:27 -0600 (Mon, 06 Dec 2010) | 22 lines

Merged revisions 297713 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r297713 | tilghman | 2010-12-06 18:21:50 -0600 (Mon, 06 Dec 2010) | 15 lines
 
 Merged revisions 297689 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r297689 | tilghman | 2010-12-06 18:07:37 -0600 (Mon, 06 Dec 2010) | 8 lines
   
   Don't create a Local channel if the target extension does not exist.
   
   (closes issue ASTERISK-16800)
    Reported by: junky
    Patches:
          followme.diff uploaded by junky (license 177)
          (partially restructured by me to avoid a possible memory leak)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=297733
By: Digium Subversion (svnbot) 2010-12-06 18:31:21.000-0600

Repository: asterisk
Revision: 297734

_U  trunk/
U   trunk/apps/app_followme.c

------------------------------------------------------------------------
r297734 | tilghman | 2010-12-06 18:31:21 -0600 (Mon, 06 Dec 2010) | 29 lines

Merged revisions 297733 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r297733 | tilghman | 2010-12-06 18:29:26 -0600 (Mon, 06 Dec 2010) | 22 lines
 
 Merged revisions 297713 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r297713 | tilghman | 2010-12-06 18:21:50 -0600 (Mon, 06 Dec 2010) | 15 lines
   
   Merged revisions 297689 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r297689 | tilghman | 2010-12-06 18:07:37 -0600 (Mon, 06 Dec 2010) | 8 lines
     
     Don't create a Local channel if the target extension does not exist.
     
     (closes issue ASTERISK-16800)
      Reported by: junky
      Patches:
            followme.diff uploaded by junky (license 177)
            (partially restructured by me to avoid a possible memory leak)
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=297734