[Home]

Summary:ASTERISK-16812: [patch] AMI command 'MeetMeList' responds with error when no conferences exist
Reporter:Corey Farrell (coreyfarrell)Labels:
Date Opened:2010-10-14 08:21:52Date Closed:2014-01-09 18:11:36.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_meetme-r319651-meetmelist_error_reporting.diff
( 1) asterisk-meetmelist-error_reporting.patch
Description:When running MeetMeList without specifying a conference (to get information on all conferences), an error is returned if no conferences exist.  I feel that this is not an error unless a 'Conference: <id>' is specified and does not exist.

On an authenticated AMI connection send:
Action: MeetMeList
ActionID: 1234

If no conferences exist, you receive:
Response: Error
ActionID: 1234
Message: No active conferences.

I would expect to instead receive:
Response: Success
ActionID: 1234
Message: No active conferences.

Or even:
Response: Success
EventList: start
Message: Meetme user list will follow

Event: MeetmeListComplete
EventList: Complete
ListItems: 0


****** ADDITIONAL INFORMATION ******

Though minor this does require special error handlers for use with this action.

I'm sure this has an effect on why I receive this error, no conferences are configured in meetme.conf.  I enter conferences in dialplan with:
MeetMe(${DYN_CONFID},AdEFoq)
So unless callers are in conferences none exist.  I use MeetMeList when connecting AMI to make sure I know of any that already exist, watch events for updates.

The documentation is also incorrect for this command.  It states that 'Conference: <confno>' is a required variable though it is not.  Please do not make it required.  I'm aware of https://issues.asterisk.org/view.php?id=17905, this patch would not replace the functionality currently provided by this command.

Tested this on 1.6.2.8 and 1.6.2.12 with the same results.
Comments:By: Leif Madsen (lmadsen) 2010-10-14 15:08:26

This sounds like a feature request for me. While this may not be what you expect to happen, it is just working as expected.

By: Corey Farrell (coreyfarrell) 2010-10-14 15:48:08

I use MeetMeList for the same thing I use CoreShowChannels (where it is not an error for no channels to be active).  My thought is that MeetMeList should only return error for the following:
* A Conference is specified and does not exist
* If app_meetme.so is not loaded

I hadn't realized this when I first submitted the request but MeetMeList does not return error if a conference is active and you request one that does not exist.  For example:
*** Submit to AMI when MeetME 1234 is the only one active
Action: MeetMeList
Conference: 4321

*** Reply from Asterisk
Response: Success
EventList: start
Message: Meetme user list will follow

Event: MeetmeListComplete
EventList: Complete
ListItems: 0


If you still feel this is a feature request please close the ticket, I don't want to break the rules.

By: Leif Madsen (lmadsen) 2010-10-14 16:16:35

This just appears to be how it works. However patches for added functionality is always welcome. Feel free to reopen this issue if you are able to provide a patch in the future. Thanks!

By: Corey Farrell (coreyfarrell) 2010-10-14 19:05:52

I looked at the code and found the changes required are trivial.  A patch will be attached once this reopens.  The patch ensures error responses are only used when a Conference is requested that isn't active, or if app_meetme.so is not loaded.  Requesting a list of users without specifying a conference will successfully return a list with 0 entries if no conferences are active.  Also touched the XML docs for the manager command to reflect that Conference is optional.

I tested the patch with trunk default ./configure on CentOS 5.5 64bit.

By: Leif Madsen (lmadsen) 2010-10-19 14:04:50

Thanks for submitting a patch! I'm marking this as Ready for Testing. Feel free ot email the asterisk-users and/or asterisk-dev mailing list requesting testers.

By: Corey Farrell (coreyfarrell) 2011-05-20 18:38:14

Sorry I got busy with a project, asterisk-meetmelist-error_reporting.patch doesn't match the current trunk anymore, please remove it.

I've tested app_meetme-r319651-meetmelist_error_reporting.diff with CentOS 5.6 x64.