Summary:	ASTERISK-16845: [patch] useropts not initialized
Reporter:	Dmitry Andrianov (dimas)	Labels:
Date Opened:	2010-10-21 17:49:52	Date Closed:	2011-05-11 13:54:10
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_meetme
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) v1-18182.patch
Description:	The useropts variable is not initilized to empty string inside find_conf_realtime so if there is not useropts column, it will receive random garbage.
Comments:	By: Dmitry Andrianov (dimas) 2010-10-21 17:53:51 I'm attaching the trivial patch which fixes the issue. However I would like to confirm one thing: how these realtime user options relate to user options already passed to meetme by the dialplan? What was the design? should they be merged or realtime options replace dialplan options? (I see what the code does but I'm curious if this is intended behavior or a bug) By: dea (dea) 2010-10-25 12:49:32 My opinion is that the options set via RealTime should replace any set via the dialplan, since the point is to allow full control for how the conference is configured. By: Dmitry Andrianov (dimas) 2010-10-25 13:36:34 as i understand this is exactly what it currently does. so it is intended... however it makes dynamic selection of options depending on dialplan variables etc not so easy task... By: Dmitry Andrianov (dimas) 2011-01-07 03:26:27.000-0600 Dear Digium, I wonder why it takes three months to accept one-line change in the code where it is clear someone just forgot to initialize the variable? It would fix this and most likely 18006 issue... By: Digium Subversion (svnbot) 2011-01-07 14:52:01.000-0600 Repository: asterisk Revision: 301089 U   branches/1.6.2/apps/app_meetme.c ------------------------------------------------------------------------ r301089 | qwell | 2011-01-07 14:52:01 -0600 (Fri, 07 Jan 2011) | 8 lines Initialize useropts/adminopts in case there is no column in the realtime DB. (closes issue ASTERISK-16845) Reported by: dimas Patches:      v1-18182.patch uploaded by dimas (license 88) Tested by: dimas ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=301089 By: Digium Subversion (svnbot) 2011-01-07 14:53:03.000-0600 Repository: asterisk Revision: 301090 _U  branches/1.8/ U   branches/1.8/apps/app_meetme.c ------------------------------------------------------------------------ r301090 | qwell | 2011-01-07 14:53:02 -0600 (Fri, 07 Jan 2011) | 15 lines Merged revisions 301089 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ........  r301089 | qwell | 2011-01-07 14:52:00 -0600 (Fri, 07 Jan 2011) | 8 lines    Initialize useropts/adminopts in case there is no column in the realtime DB.    (closes issue ASTERISK-16845)  Reported by: dimas  Patches:        v1-18182.patch uploaded by dimas (license 88)  Tested by: dimas ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=301090 By: Digium Subversion (svnbot) 2011-01-07 14:53:46.000-0600 Repository: asterisk Revision: 301091 _U  trunk/ U   trunk/apps/app_meetme.c ------------------------------------------------------------------------ r301091 | qwell | 2011-01-07 14:53:46 -0600 (Fri, 07 Jan 2011) | 22 lines Merged revisions 301090 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................  r301090 | qwell | 2011-01-07 14:53:02 -0600 (Fri, 07 Jan 2011) | 15 lines    Merged revisions 301089 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.6.2    ........    r301089 | qwell | 2011-01-07 14:52:00 -0600 (Fri, 07 Jan 2011) | 8 lines        Initialize useropts/adminopts in case there is no column in the realtime DB.        (closes issue ASTERISK-16845)    Reported by: dimas    Patches:          v1-18182.patch uploaded by dimas (license 88)    Tested by: dimas  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=301091