[Home]

Summary:ASTERISK-16897: [patch] can't have a conversation between two users if the only allowed codec is speex16.
Reporter:David Menard (whizemen)Labels:
Date Opened:2010-11-01 10:19:42Date Closed:2011-01-19 09:34:09.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_local
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 0018238_speex16.patch
Description:can't have a conversation between two users if the only allowed codec is speex16.

ast_best_codec receives 0x0 as possible format.  int64 cast in int32

****** ADDITIONAL INFORMATION ******

here are the changes I did to fixe it

<inline patch removed by lmadsen>
Comments:By: Leif Madsen (lmadsen) 2010-11-02 09:24:47

You can't post patches inline like that. Please attach patches as a unified diff after signing the electronic license agreement (only need to do it once).
By: David Menard (whizemen) 2010-11-02 09:40:13

sorry, won't do it again. Here is the diff file(patch) attached.


By: Sean Bright (seanbright) 2011-01-18 16:17:14.000-0600

This looks good to me.
By: Digium Subversion (svnbot) 2011-01-19 09:31:42.000-0600

Repository: asterisk
Revision: 302412

U   branches/1.8/channels/chan_local.c

------------------------------------------------------------------------
r302412 | seanbright | 2011-01-19 09:31:41 -0600 (Wed, 19 Jan 2011) | 10 lines

Use appropriate type for requested format in chan_local.

We were passing and storing the requested format as an int instead of format_t
resulting in truncation.

(closes issue ASTERISK-16897)
Reported by: whizemen
Patches:
     0018238_speex16.patch uploaded by whizemen (license 1143)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=302412
By: Digium Subversion (svnbot) 2011-01-19 09:34:08.000-0600

Repository: asterisk
Revision: 302413

_U  trunk/
U   trunk/channels/chan_local.c

------------------------------------------------------------------------
r302413 | seanbright | 2011-01-19 09:34:08 -0600 (Wed, 19 Jan 2011) | 17 lines

Merged revisions 302412 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r302412 | seanbright | 2011-01-19 10:31:39 -0500 (Wed, 19 Jan 2011) | 10 lines
 
 Use appropriate type for requested format in chan_local.
 
 We were passing and storing the requested format as an int instead of format_t
 resulting in truncation.
 
 (closes issue ASTERISK-16897)
 Reported by: whizemen
 Patches:
       0018238_speex16.patch uploaded by whizemen (license 1143)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=302413