Summary: | ASTERISK-16903: [patch] adding the CALENDARSTATUS for CALENDAR_WRITE() | ||
Reporter: | Clod Patry (junky) | Labels: | |
Date Opened: | 2010-11-02 23:04:59 | Date Closed: | 2012-01-27 16:51:53.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Resources/res_calendar/NewFeature |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) calendarstatus.diff | |
Description: | right now, when CALENDAR_WRITE() is failing, you only see a LOG_WARNING. There's no way to see that a write has failed. That could be useful to write in a future time. This patch set the chanvar to FAILURE or SUCCESS based on the action of the CALENDAR_WRITE. | ||
Comments: | By: Leif Madsen (lmadsen) 2010-11-18 15:22:55.000-0600 <para>This is the status to the write's operation to the calendar</para> I'd prefer: <para>The status of the write operation to the calendar</para> Beyond that, I say Ship It! By: Terry Wilson (twilson) 2012-01-18 17:01:41.129-0600 This patch looks good. The only change I'd make is to make CALENDARSTATUS return "1" or "0" so one could just do GotoIf(${CALENDARSTATUS}?succes,failure) instead of having to do string comparison (this would make it consistent to how the CALENDAR_BUSY() function returns). The else clause added in res_calendar_caldav is unnecessary since -1 is the default value. res_calendar_exchange also needs the response check. It looks like res_calendar_ews should be fine. I don't mind making these changes myself before committing, but I wanted to make sure that they sounded reasonable to you before doing anything. Thanks! |