| Summary: | ASTERISK-16910: Newstate event contains CallerIDName/CallerIDNum of queue member | ||||
| Reporter: | Gert-Jan (gje) | Labels: | |||
| Date Opened: | 2010-11-04 11:07:58 | Date Closed: | 2011-05-26 08:04:40 | ||
| Priority: | Minor | Regression? | No | ||
| Status: | Closed/Complete | Components: | Applications/app_queue | ||
| Versions: | Frequency of Occurrence | ||||
| Related Issues: |
| ||||
| Environment: | Attachments: | ( 0) issue_0018252_1.4.33.1_full.log ( 1) issue_0018252_1.8.0_full.log | |||
| Description: | The Newstate event message contains different information with regarding to asterisk 1.4 and 1.8. The CallerIDName/CallerIDNum (ast 1.8) contains the caller info of the queue member. The CallerIDName/CallerID (ast 1.4) contains the caller info of the person which is in the queue. The CallerIDName/Num is showed correctly (MR X <12345>) on the display of phone of the queue member. ****** ADDITIONAL INFORMATION ****** Asterisk 1.8.0 AMI: ChannelState: 5 Channel: SIP/671-00000009 CallerIDName: 3CX Phone ChannelStateDesc: Ringing CallerIDNum: 671 Event: Newstate Privilege: call,all Uniqueid: 1288884533.9 Asterisk 1.4.33.1 AMI: State: Ringing Channel: SIP/671-00000003 CallerIDName: MR X CallerID: 12345 Event: Newstate Privilege: call,all Uniqueid: 1288885350.3 Used configurations: extensions.conf: [do_support] exten => s,1,Wait(0.5) exten => s,n,Set(CALLERID(name)=MR X) ; Fixed caller name and ID for debugging exten => s,n,Set(CALLERID(num)=12345) exten => s,n,Queue(queue_support|tT|||1800) exten => s,n,Hangup() queues.conf: [queue_support] music = default strategy = ringall context = queue_support_out timeout = 15 retry = 2 wrapuptime = 0 announce-frequency = 90 announce-holdtime = no joinempty = yes ringinuse = yes member => SIP/671 | ||||
| Comments: | By: Paul Belanger (pabelanger) 2010-11-04 12:04:14 Please upload a debug log (see below), I'd like to see what is going on. --- We require a complete debug log to help triage the issue. This document will provide instructions on how to collect debugging logs from an Asterisk machine for the purpose of helping bug marshals troubleshoot an issue: https://wiki.asterisk.org/wiki/display/AST/Collecting+Debug+Information By: Gert-Jan (gje) 2010-11-04 14:31:11 I've uploaded two debug log files; one created by v1.4.33.1 and one created by v1.8.0. Actions performed during the log: - SIP/623 calls 500 (which is the queue). - SIP/671 is ringing (which is a queue member). - SIP/623 hangs up (after a few seconds). Hope this will help you. By: Bernard Merindol (bernard merindol) 2010-12-03 16:04:16.000-0600 The problem is in ring_entry function: In 1.6 we have: if (tmp->chan->cid.cid_num) ast_free(tmp->chan->cid.cid_num); tmp->chan->cid.cid_num = ast_strdup(qe->chan->cid.cid_num); ... In 1.8 if (!tmp->chan->caller.id.number.valid) { if (qe->chan->connected.id.number.valid) { struct ast_party_caller caller; The test is the oposit. If change just with if (tmp->chan->caller.id.number.valid) { The event return good. By: Richard Mudgett (rmudgett) 2011-05-23 15:33:10 The addition of connected line support in Asterisk v1.8 changes the behavior of the channel caller ID somewhat. The channel caller ID value no longer time shares with the connected line ID on outgoing call legs. The timing of some AMI events/responses output the connected line ID as caller ID. These party ID's are now separate. See the reviewboard patch: https://reviewboard.asterisk.org/r/1227/ The patch adds ConnectedLineNum and ConnectedLineName AMI headers. By: Digium Subversion (svnbot) 2011-05-26 08:04:31 Repository: asterisk Revision: 320823 U branches/1.8/CHANGES U branches/1.8/UPGRADE.txt U branches/1.8/apps/app_dial.c U branches/1.8/apps/app_fax.c U branches/1.8/apps/app_meetme.c U branches/1.8/apps/app_queue.c U branches/1.8/main/channel.c U branches/1.8/main/features.c U branches/1.8/main/manager.c ------------------------------------------------------------------------ r320823 | rmudgett | 2011-05-26 08:04:31 -0500 (Thu, 26 May 2011) | 18 lines The AMI Newstate event contains different information between v1.4 and v1.8. The addition of connected line support in v1.8 changes the behavior of the channel caller ID somewhat. The channel caller ID value no longer time shares with the connected line ID on outgoing call legs. The timing of some AMI events/responses output the connected line ID as caller ID. These party ID's are now separate. * The ConnectedLineNum and ConnectedLineName headers were added to many AMI events/responses if the CallerIDNum/CallerIDName headers were also present. (closes issue ASTERISK-16910) Reported by: gje Tested by: rmudgett Review: https://reviewboard.asterisk.org/r/1227/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=320823 By: Digium Subversion (svnbot) 2011-05-26 08:04:40 Repository: asterisk Revision: 320825 _U trunk/ U trunk/CHANGES U trunk/UPGRADE-1.8.txt U trunk/apps/app_dial.c U trunk/apps/app_fax.c U trunk/apps/app_meetme.c U trunk/apps/app_queue.c U trunk/main/channel.c U trunk/main/features.c U trunk/main/manager.c ------------------------------------------------------------------------ r320825 | rmudgett | 2011-05-26 08:04:39 -0500 (Thu, 26 May 2011) | 25 lines Merged revisions 320823 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........ r320823 | rmudgett | 2011-05-25 12:06:38 -0500 (Wed, 25 May 2011) | 18 lines The AMI Newstate event contains different information between v1.4 and v1.8. The addition of connected line support in v1.8 changes the behavior of the channel caller ID somewhat. The channel caller ID value no longer time shares with the connected line ID on outgoing call legs. The timing of some AMI events/responses output the connected line ID as caller ID. These party ID's are now separate. * The ConnectedLineNum and ConnectedLineName headers were added to many AMI events/responses if the CallerIDNum/CallerIDName headers were also present. (closes issue ASTERISK-16910) Reported by: gje Tested by: rmudgett Review: https://reviewboard.asterisk.org/r/1227/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=320825 | ||||