[Home]

Summary:ASTERISK-16921: [patch] Dail L(x) shows "Setting call duration limit to x seconds" in CLI
Reporter:Jacco van Tuijl (jacco)Labels:
Date Opened:2010-11-05 07:52:36Date Closed:2011-01-21 10:29:23.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_dial
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_dial_patch.txt
Description:dial(SIP/${EXTEN},60,L(18000))

Shows:
"Setting call duration limit to 18000 seconds"
in CLI

It should Show:
"Setting call duration limit to 18000 milliseconds"
in CLI
Comments:By: Leif Madsen (lmadsen) 2010-11-18 14:59:03.000-0600

Does this work?
By: Jacco van Tuijl (jacco) 2011-01-06 09:38:09.000-0600

yes, it works
By: Leif Madsen (lmadsen) 2011-01-06 09:59:45.000-0600

Awesome! I'll get it committed then. Thanks!
By: Ronald Chan (loloski) 2011-01-07 08:35:08.000-0600

can this be commited ? thanks
By: Digium Subversion (svnbot) 2011-01-20 09:38:34.000-0600

Repository: asterisk
Revision: 302916

U   branches/1.4/apps/app_dial.c

------------------------------------------------------------------------
r302916 | lmadsen | 2011-01-20 09:38:34 -0600 (Thu, 20 Jan 2011) | 9 lines

Option L() is milliseconds, not seconds.
Change the verbose output of option L() to say milliseconds and not seconds
as the value is in milliseconds.

(closes issue ASTERISK-16921)
Reported by: jacco
Patches:
     app_dial_patch.txt uploaded by lmadsen (license 10)
Tested by: lmadsen, jacco
------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=302916
By: Digium Subversion (svnbot) 2011-01-20 09:42:06.000-0600

Repository: asterisk
Revision: 302917

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_dial.c

------------------------------------------------------------------------
r302917 | lmadsen | 2011-01-20 09:42:05 -0600 (Thu, 20 Jan 2011) | 8 lines

Option L() is milliseconds, not seconds.
> Change the verbose output of option L() to say milliseconds and not seconds
> as the value is in milliseconds.
>
> (closes issue ASTERISK-16921)
> Reported by: jacco
> Patches:
>       app_dial_patch.txt uploaded by lmadsen (license 10)
------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=302917
By: Digium Subversion (svnbot) 2011-01-20 09:45:40.000-0600

Repository: asterisk
Revision: 302918

_U  branches/1.8/
U   branches/1.8/apps/app_dial.c

------------------------------------------------------------------------
r302918 | lmadsen | 2011-01-20 09:45:40 -0600 (Thu, 20 Jan 2011) | 16 lines

Merged revisions 302917 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r302917 | lmadsen | 2011-01-20 09:42:05 -0600 (Thu, 20 Jan 2011) | 8 lines
 
 Option L() is milliseconds, not seconds.
 > Change the verbose output of option L() to say milliseconds and not seconds
 > as the value is in milliseconds.
 >
 > (closes issue ASTERISK-16921)
 > Reported by: jacco
 > Patches:
 >       app_dial_patch.txt uploaded by lmadsen (license 10)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=302918
By: Digium Subversion (svnbot) 2011-01-20 09:46:26.000-0600

Repository: asterisk
Revision: 302919

_U  trunk/
U   trunk/apps/app_dial.c

------------------------------------------------------------------------
r302919 | lmadsen | 2011-01-20 09:46:25 -0600 (Thu, 20 Jan 2011) | 23 lines

Merged revisions 302918 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r302918 | lmadsen | 2011-01-20 09:45:39 -0600 (Thu, 20 Jan 2011) | 16 lines
 
 Merged revisions 302917 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r302917 | lmadsen | 2011-01-20 09:42:05 -0600 (Thu, 20 Jan 2011) | 8 lines
   
   Option L() is milliseconds, not seconds.
   > Change the verbose output of option L() to say milliseconds and not seconds
   > as the value is in milliseconds.
   >
   > (closes issue ASTERISK-16921)
   > Reported by: jacco
   > Patches:
   >       app_dial_patch.txt uploaded by lmadsen (license 10)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=302919
By: Digium Subversion (svnbot) 2011-01-21 10:12:55.000-0600

Repository: asterisk
Revision: 303273

U   branches/1.6.2/apps/app_dial.c

------------------------------------------------------------------------
r303273 | lmadsen | 2011-01-21 10:12:54 -0600 (Fri, 21 Jan 2011) | 9 lines

Fix changes to L() flag in Dial().

Tony Mountifield pointed out an error I had in my patch. I was a bit too aggressive
on changing 'seconds' to 'milliseconds'. So I decided to do some additioanl testing
and have no changed just the appropriate lines. One line says milliseconds, and the
other says seconds. Probably should change this to be either just seconds or
milliseconds, but I've spent too much time on this already :)

(issue ASTERISK-16921)
------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=303273
By: Digium Subversion (svnbot) 2011-01-21 10:29:23.000-0600

Repository: asterisk
Revision: 303274

_U  branches/1.8/

------------------------------------------------------------------------
r303274 | lmadsen | 2011-01-21 10:29:23 -0600 (Fri, 21 Jan 2011) | 16 lines

Blocked revisions 303273 via svnmerge

........
 r303273 | lmadsen | 2011-01-21 10:12:54 -0600 (Fri, 21 Jan 2011) | 9 lines
 
 Fix changes to L() flag in Dial().
 
 Tony Mountifield pointed out an error I had in my patch. I was a bit too aggressive
 on changing 'seconds' to 'milliseconds'. So I decided to do some additioanl testing
 and have no changed just the appropriate lines. One line says milliseconds, and the
 other says seconds. Probably should change this to be either just seconds or
 milliseconds, but I've spent too much time on this already :)
 
 (issue ASTERISK-16921)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=303274