[Home]

Summary:ASTERISK-16932: [patch] res_odbc using ^ separator in M(macro) option as argument separator in Dial app gives control characters
Reporter:Alan Graham (zerohalo)Labels:
Date Opened:2010-11-08 17:14:07.000-0600Date Closed:2010-12-16 03:06:23.000-0600
Priority:BlockerRegression?No
Status:Closed/CompleteComponents:Resources/res_config_odbc
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20101109__issue18279.diff.txt
Description:I believe I've seen this in the tracker before, but can't find it - feel free to close this and redirect me.

in dialplan:

exten => s,1,Dial(${INTERFACE},${RINGTIME},rM(setmoh^accmusic))

the ^ seems to become an escape that mangles the argument (in this case, the moh class):

[2010-11-07 08:03:08] WARNING[13261] app_macro.c: No such context 'macro-setmoh¬cmusic' for macro 'setmoh¬cmusic'

this does not appear to happen using res_config_mysql.
Comments:By: Alan Graham (zerohalo) 2010-11-09 09:57:56.000-0600

sorry - should read res_config_odbc and res_config_mysql.
By: Tilghman Lesher (tilghman) 2010-11-09 12:22:18.000-0600

Correct, we use the ^ as an escape character to encode literal semicolons within realtime, to avoid them from being used as a separator to multiple occurrences of the same key.
By: Alan Graham (zerohalo) 2010-11-11 10:10:02.000-0600

That fixed it - thanks!
By: Digium Subversion (svnbot) 2010-12-16 03:03:44.000-0600

Repository: asterisk
Revision: 298480

U   branches/1.4/res/res_config_odbc.c

------------------------------------------------------------------------
r298480 | tilghman | 2010-12-16 03:03:41 -0600 (Thu, 16 Dec 2010) | 14 lines

Only increment the pointer once per loop, otherwise we corrupt the value.

(closes issue ASTERISK-16909)
Reported by: bcnit
Patches:
      20101110__issue18251.diff.txt uploaded by tilghman (license 14)
Tested by: trev, jthurman, elguero

(closes issue ASTERISK-16932)
Reported by: zerohalo
Patches:
      20101109__issue18279.diff.txt uploaded by tilghman (license 14)
Tested by: zerohalo

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=298480
By: Digium Subversion (svnbot) 2010-12-16 03:04:40.000-0600

Repository: asterisk
Revision: 298481

_U  branches/1.6.2/
U   branches/1.6.2/res/res_config_odbc.c

------------------------------------------------------------------------
r298481 | tilghman | 2010-12-16 03:04:39 -0600 (Thu, 16 Dec 2010) | 21 lines

Merged revisions 298480 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r298480 | tilghman | 2010-12-16 03:03:40 -0600 (Thu, 16 Dec 2010) | 14 lines
 
 Only increment the pointer once per loop, otherwise we corrupt the value.
 
 (closes issue ASTERISK-16909)
  Reported by: bcnit
  Patches:
        20101110__issue18251.diff.txt uploaded by tilghman (license 14)
  Tested by: trev, jthurman, elguero
 
 (closes issue ASTERISK-16932)
  Reported by: zerohalo
  Patches:
        20101109__issue18279.diff.txt uploaded by tilghman (license 14)
  Tested by: zerohalo
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=298481
By: Digium Subversion (svnbot) 2010-12-16 03:05:30.000-0600

Repository: asterisk
Revision: 298482

_U  branches/1.8/
U   branches/1.8/res/res_config_odbc.c

------------------------------------------------------------------------
r298482 | tilghman | 2010-12-16 03:05:29 -0600 (Thu, 16 Dec 2010) | 28 lines

Merged revisions 298481 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r298481 | tilghman | 2010-12-16 03:04:38 -0600 (Thu, 16 Dec 2010) | 21 lines
 
 Merged revisions 298480 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r298480 | tilghman | 2010-12-16 03:03:40 -0600 (Thu, 16 Dec 2010) | 14 lines
   
   Only increment the pointer once per loop, otherwise we corrupt the value.
   
   (closes issue ASTERISK-16909)
    Reported by: bcnit
    Patches:
          20101110__issue18251.diff.txt uploaded by tilghman (license 14)
    Tested by: trev, jthurman, elguero
   
   (closes issue ASTERISK-16932)
    Reported by: zerohalo
    Patches:
          20101109__issue18279.diff.txt uploaded by tilghman (license 14)
    Tested by: zerohalo
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=298482
By: Digium Subversion (svnbot) 2010-12-16 03:06:23.000-0600

Repository: asterisk
Revision: 298483

_U  trunk/
U   trunk/res/res_config_odbc.c

------------------------------------------------------------------------
r298483 | tilghman | 2010-12-16 03:06:21 -0600 (Thu, 16 Dec 2010) | 35 lines

Merged revisions 298482 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r298482 | tilghman | 2010-12-16 03:05:28 -0600 (Thu, 16 Dec 2010) | 28 lines
 
 Merged revisions 298481 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r298481 | tilghman | 2010-12-16 03:04:38 -0600 (Thu, 16 Dec 2010) | 21 lines
   
   Merged revisions 298480 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r298480 | tilghman | 2010-12-16 03:03:40 -0600 (Thu, 16 Dec 2010) | 14 lines
     
     Only increment the pointer once per loop, otherwise we corrupt the value.
     
     (closes issue ASTERISK-16909)
      Reported by: bcnit
      Patches:
            20101110__issue18251.diff.txt uploaded by tilghman (license 14)
      Tested by: trev, jthurman, elguero
     
     (closes issue ASTERISK-16932)
      Reported by: zerohalo
      Patches:
            20101109__issue18279.diff.txt uploaded by tilghman (license 14)
      Tested by: zerohalo
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=298483