| Summary: | ASTERISK-16936: [patch] Manager eventfilter: black filters aren't applied properly | ||
| Reporter: | Sergio González Martín (telecos82) | Labels: | |
| Date Opened: | 2010-11-09 10:16:42.000-0600 | Date Closed: | 2011-02-04 16:37:13.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/ManagerInterface |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) ast_managereventfilter.patch | |
| Description: | When having defined more than one black filters on eventfilter parameters, they do not apply properly: none of them matches. It only works if you have only one black filter defined. For example, if we have: eventfilter = !Event: Newexten.*Application: Playback eventfilter = !Event: Newexten.*Application: Answer both Newexten events will be received, despite we are trying to avoid them. The problem is that when comparing with blackfilters, it stops comparing when the Event does not match with a filter (which means accept the Event), but as we are comparing for black filters, we should stop only when we match a filter and then discard the event. | ||
| Comments: | By: Digium Subversion (svnbot) 2011-02-04 16:37:13.000-0600 Repository: asterisk Revision: 306432 U trunk/main/manager.c ------------------------------------------------------------------------ r306432 | jpeeler | 2011-02-04 16:37:12 -0600 (Fri, 04 Feb 2011) | 10 lines Send manager event for blackfilter only if it DOES NOT match. The logic got reversed, oops. Works properly now when multiple blackfilters are present. (closes issue ASTERISK-16936) Reported by: telecos82 Patches: ast_managereventfilter.patch uploaded by telecos82 (license 687) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=306432 | ||