| Summary: | ASTERISK-16957: [patch] Asterisk does not play wav files with unknown chunk types | ||
| Reporter: | Jakob Hirsch (jhirsch) | Labels: | |
| Date Opened: | 2010-11-15 03:51:04.000-0600 | Date Closed: | 2011-04-25 14:40:19 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Formats/format_wav |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) wav_skip_unknown_blocks.diff | |
| Description: | Asterisk bails on unknown chunks in wav files instead of simply skipping them (like it does with "fact" chunks). ****** ADDITIONAL INFORMATION ****** We allow our users to upload their wav files for their voicemail announcements and they happen to contain chunks like "LIST", which contain nothing useful for asterisk, but do not harm either. | ||
| Comments: | By: Leif Madsen (lmadsen) 2010-12-06 13:11:13.000-0600 Thanks for the patch! By: Digium Subversion (svnbot) 2011-04-25 14:28:42 Repository: asterisk Revision: 315257 U branches/1.4/formats/format_wav.c ------------------------------------------------------------------------ r315257 | russell | 2011-04-25 14:28:42 -0500 (Mon, 25 Apr 2011) | 10 lines Be more flexible with unknown chunks in wav files. This patch makes format_wav ignore unknown chunks instead of erroring out on them. (closes issue ASTERISK-16957) Reported by: jhirsch Patches: wav_skip_unknown_blocks.diff uploaded by jhirsch (license 1156) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=315257 By: Digium Subversion (svnbot) 2011-04-25 14:31:45 Repository: asterisk Revision: 315258 _U branches/1.6.2/ U branches/1.6.2/formats/format_wav.c ------------------------------------------------------------------------ r315258 | russell | 2011-04-25 14:31:45 -0500 (Mon, 25 Apr 2011) | 17 lines Merged revisions 315257 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r315257 | russell | 2011-04-25 14:28:41 -0500 (Mon, 25 Apr 2011) | 10 lines Be more flexible with unknown chunks in wav files. This patch makes format_wav ignore unknown chunks instead of erroring out on them. (closes issue ASTERISK-16957) Reported by: jhirsch Patches: wav_skip_unknown_blocks.diff uploaded by jhirsch (license 1156) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=315258 By: Digium Subversion (svnbot) 2011-04-25 14:37:33 Repository: asterisk Revision: 315259 _U branches/1.8/ U branches/1.8/formats/format_wav.c ------------------------------------------------------------------------ r315259 | russell | 2011-04-25 14:37:33 -0500 (Mon, 25 Apr 2011) | 24 lines Merged revisions 315258 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ................ r315258 | russell | 2011-04-25 14:31:44 -0500 (Mon, 25 Apr 2011) | 17 lines Merged revisions 315257 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r315257 | russell | 2011-04-25 14:28:41 -0500 (Mon, 25 Apr 2011) | 10 lines Be more flexible with unknown chunks in wav files. This patch makes format_wav ignore unknown chunks instead of erroring out on them. (closes issue ASTERISK-16957) Reported by: jhirsch Patches: wav_skip_unknown_blocks.diff uploaded by jhirsch (license 1156) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=315259 By: Digium Subversion (svnbot) 2011-04-25 14:40:18 Repository: asterisk Revision: 315260 _U trunk/ U trunk/formats/format_wav.c ------------------------------------------------------------------------ r315260 | russell | 2011-04-25 14:40:18 -0500 (Mon, 25 Apr 2011) | 31 lines Merged revisions 315259 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................ r315259 | russell | 2011-04-25 14:37:32 -0500 (Mon, 25 Apr 2011) | 24 lines Merged revisions 315258 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ................ r315258 | russell | 2011-04-25 14:31:44 -0500 (Mon, 25 Apr 2011) | 17 lines Merged revisions 315257 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r315257 | russell | 2011-04-25 14:28:41 -0500 (Mon, 25 Apr 2011) | 10 lines Be more flexible with unknown chunks in wav files. This patch makes format_wav ignore unknown chunks instead of erroring out on them. (closes issue ASTERISK-16957) Reported by: jhirsch Patches: wav_skip_unknown_blocks.diff uploaded by jhirsch (license 1156) ........ ................ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=315260 | ||