Summary:	ASTERISK-17006: [patch] Cannot forward voicemail with file storage backend
Reporter:	Daniel Hazelbaker (cabal95)	Labels:
Date Opened:	2010-11-23 13:28:57.000-0600	Date Closed:	2011-01-07 13:58:55.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) EXISTS_conditional.patch
Description:	We are running Asterisk 1.8.0 and cannot forward voicemail.  We have "file storage" backed voicemail with most users having notify + delete via e-mail turned on.  The ones that have it turned off (voicemail stays on the file system) cannot forward voicemail.  The message notification will go through with a 0-byte attachment. I have traced it to, I believe, the copy_message() function. At or around line app_voicemail.c:5165 inside the copy_message() function there is a call to vm_delete() after the message is copied. I commented out this line and voicemail forwarding seems to be working correctly.
Comments:	By: Daniel Kenzelmann (daniel kenzelmann) 2010-11-24 13:49:51.000-0600 This is also an issue if you send the call to multiple mailboxes, e.g. Voicemail(101&102) Only the first mailbox will have the message, the second mailbox does not contain anything! Which is especially bad if you have the option "delete=1" for the first mailbox. I see this in the log (version is asterisk-1.8 on gentoo) [Nov 24 19:28:41] NOTICE[3168]: app_voicemail.c:5154 copy_message: Copying message from 101@default to 102@default By: Jim Capp (jcapp) 2010-12-13 21:00:50.000-0600 I have verified this problem exists in 1.8.0 and 1.8.1 but not 1.6.2.5.  It appears that an EXISTS conditional was removed, resulting in vm_delete being called as part of the ODBC cleanup.  I do not believe the EXISTS conditional should have been removed.  A patch restoring this section of code to the same functionality as its 1.6.2.5 counterpart will follow. By: Jim Capp (jcapp) 2010-12-13 21:03:16.000-0600 A patch has been submitted as EXISTS_conditional.patch By: Jonathan Bailey (jcbailey2) 2010-12-14 08:41:57.000-0600 I've also experienced this issue on 1.6.2.15. The attached patch resolved the issue for me. By: Chad Wallace (cmdrwalrus) 2010-12-16 17:46:18.000-0600 We're experiencing this issue in 1.4.38.  I came to the same conclusion as jcapp prior to finding this report.  The offending change was svn rev. 289873, to fix ASTERISK-16514. I'll try reverting it tonight, and see how it works for me. By: Chad Wallace (cmdrwalrus) 2010-12-17 04:00:39.000-0600 OK!  I reverse-merged svn rev. 289873, and now forwarding voicemails works like a charm.   However, the ODBC storage folks will now need a new solution for ASTERISK-16514, probably one that includes #ifdefs, despite the hubristic comment in the code... By: Robert Frantik (rfrantik) 2010-12-30 12:09:51.000-0600 Just wanted to add that we are running 1.6.2.15, discovered this issue today.  Applied the patch, rebooted... seems to be fine now.  Thanks. By: Digium Subversion (svnbot) 2011-01-07 13:57:44.000-0600 Repository: asterisk Revision: 301046 U   branches/1.6.2/apps/app_voicemail.c ------------------------------------------------------------------------ r301046 | jpeeler | 2011-01-07 13:57:43 -0600 (Fri, 07 Jan 2011) | 8 lines Fix regression causing forwarding voicemails to not work with file storage. I had actually already fixed this in 295200 in 1.4 and thought it wasn't missing in the other branches for some reason. (closes issue ASTERISK-17006) Reported by: cabal95 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=301046 By: Digium Subversion (svnbot) 2011-01-07 13:58:31.000-0600 Repository: asterisk Revision: 301047 _U  branches/1.8/ U   branches/1.8/apps/app_voicemail.c ------------------------------------------------------------------------ r301047 | jpeeler | 2011-01-07 13:58:31 -0600 (Fri, 07 Jan 2011) | 15 lines Merged revisions 301046 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ........  r301046 | jpeeler | 2011-01-07 13:57:42 -0600 (Fri, 07 Jan 2011) | 8 lines    Fix regression causing forwarding voicemails to not work with file storage.    I had actually already fixed this in 295200 in 1.4 and thought it wasn't  missing in the other branches for some reason.    (closes issue ASTERISK-17006)  Reported by: cabal95 ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=301047 By: Digium Subversion (svnbot) 2011-01-07 13:58:54.000-0600 Repository: asterisk Revision: 301048 _U  trunk/ U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r301048 | jpeeler | 2011-01-07 13:58:53 -0600 (Fri, 07 Jan 2011) | 22 lines Merged revisions 301047 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................  r301047 | jpeeler | 2011-01-07 13:58:30 -0600 (Fri, 07 Jan 2011) | 15 lines    Merged revisions 301046 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.6.2    ........    r301046 | jpeeler | 2011-01-07 13:57:42 -0600 (Fri, 07 Jan 2011) | 8 lines        Fix regression causing forwarding voicemails to not work with file storage.        I had actually already fixed this in 295200 in 1.4 and thought it wasn't    missing in the other branches for some reason.        (closes issue ASTERISK-17006)    Reported by: cabal95  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=301048