[Home]

Summary:ASTERISK-17018: [patch] asterisk crash when dialing SIP/${var} where var is empty or not set
Reporter:Guillaume Bour (gbour)Labels:
Date Opened:2010-11-24 08:58:12.000-0600Date Closed:2011-01-31 17:08:40.000-0600
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 18371.patch
( 1) extensions.conf
( 2) gdb_trace.txt
Description:exten = 500,1,NoOp()
exten = 500,n,Set(var=)
exten = 500,n,Dial(SIP/${var})

if var is not set or empy, executing Dial(SIP/${var}) make asterisk crash
Comments:By: Guillaume Bour (gbour) 2010-11-24 09:34:58.000-0600

And here is the patch
By: Leif Madsen (lmadsen) 2010-12-07 10:46:31.000-0600

Thanks for the patch! That is not a good crash :)
By: Leif Madsen (lmadsen) 2010-12-07 10:46:51.000-0600

Is it only for chan_sip, or does it happen inside the app_dial?
By: Leif Madsen (lmadsen) 2010-12-07 10:47:07.000-0600

Ah patch is in chan_sip.
By: Guillaume Bour (gbour) 2010-12-08 03:05:13.000-0600

No, its only for chan_sip. Tested with IAX, it does not segfault
By: Digium Subversion (svnbot) 2011-01-31 16:56:56.000-0600

Repository: asterisk
Revision: 305252

U   branches/1.4/apps/app_dial.c
U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r305252 | qwell | 2011-01-31 16:56:55 -0600 (Mon, 31 Jan 2011) | 10 lines

Prevent a crash when dialing a technology with no destination (ex: Dial(SIP/))

chan_iax2 and other channel drivers already had code to prevent this.  The
attempt that app_dial was making to prevent it was not correct, so I fixed that.

(closes issue ASTERISK-17018)
Reported by: gbour
Patches:
     18371.patch uploaded by gbour (license 1162)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=305252
By: Digium Subversion (svnbot) 2011-01-31 16:59:35.000-0600

Repository: asterisk
Revision: 305253

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_dial.c
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r305253 | qwell | 2011-01-31 16:59:34 -0600 (Mon, 31 Jan 2011) | 17 lines

Merged revisions 305252 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r305252 | qwell | 2011-01-31 16:56:54 -0600 (Mon, 31 Jan 2011) | 10 lines
 
 Prevent a crash when dialing a technology with no destination (ex: Dial(SIP/))
 
 chan_iax2 and other channel drivers already had code to prevent this.  The
 attempt that app_dial was making to prevent it was not correct, so I fixed that.
 
 (closes issue ASTERISK-17018)
 Reported by: gbour
 Patches:
       18371.patch uploaded by gbour (license 1162)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=305253
By: Digium Subversion (svnbot) 2011-01-31 17:07:01.000-0600

Repository: asterisk
Revision: 305254

_U  branches/1.8/
U   branches/1.8/apps/app_dial.c
U   branches/1.8/channels/chan_sip.c

------------------------------------------------------------------------
r305254 | qwell | 2011-01-31 17:07:01 -0600 (Mon, 31 Jan 2011) | 24 lines

Merged revisions 305253 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r305253 | qwell | 2011-01-31 16:59:34 -0600 (Mon, 31 Jan 2011) | 17 lines
 
 Merged revisions 305252 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r305252 | qwell | 2011-01-31 16:56:54 -0600 (Mon, 31 Jan 2011) | 10 lines
   
   Prevent a crash when dialing a technology with no destination (ex: Dial(SIP/))
   
   chan_iax2 and other channel drivers already had code to prevent this.  The
   attempt that app_dial was making to prevent it was not correct, so I fixed that.
   
   (closes issue ASTERISK-17018)
   Reported by: gbour
   Patches:
         18371.patch uploaded by gbour (license 1162)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=305254
By: Digium Subversion (svnbot) 2011-01-31 17:08:39.000-0600

Repository: asterisk
Revision: 305255

_U  trunk/
U   trunk/apps/app_dial.c
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r305255 | qwell | 2011-01-31 17:08:39 -0600 (Mon, 31 Jan 2011) | 31 lines

Merged revisions 305254 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r305254 | qwell | 2011-01-31 17:07:00 -0600 (Mon, 31 Jan 2011) | 24 lines
 
 Merged revisions 305253 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r305253 | qwell | 2011-01-31 16:59:34 -0600 (Mon, 31 Jan 2011) | 17 lines
   
   Merged revisions 305252 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r305252 | qwell | 2011-01-31 16:56:54 -0600 (Mon, 31 Jan 2011) | 10 lines
     
     Prevent a crash when dialing a technology with no destination (ex: Dial(SIP/))
     
     chan_iax2 and other channel drivers already had code to prevent this.  The
     attempt that app_dial was making to prevent it was not correct, so I fixed that.
     
     (closes issue ASTERISK-17018)
     Reported by: gbour
     Patches:
           18371.patch uploaded by gbour (license 1162)
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=305255