[Home]

Summary:ASTERISK-17029: [patch] one-way-audio when chanspy activated
Reporter:Jeremy Kister (jkister)Labels:
Date Opened:2010-11-25 20:18:13.000-0600Date Closed:2011-05-04 09:26:37
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_chanspy
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 0001-Bugfix-18382-one-way-audio-when-chanspy-activated.patch
( 1) 0001-Bugfix-18382-one-way-audio-when-chanspy-activated.patch.txt
( 2) extensions.conf
( 3) sip.conf
Description:* 112 calls 111
 - two-way-audio is fine
* 143 extenspies 111 (or 112)
 - 112's microphone is heard by 143 but not by 111
 - 111's microphone is heard by 143 and 111
* 143 exits the extenspy
 - two-way audio works correctly again

note: x112 is a SLT connected to a cisco 1760


****** ADDITIONAL INFORMATION ******


   -- Executing [*7@extensions:6] ExtenSpy("SIP/143-00000042", "112,qw") in new stack
 == Spying on channel SIP/vgw1-00000040
[Nov 25 21:05:54] NOTICE[14686]: app_chanspy.c:479 start_spying: Attaching SIP/143-00000042 to SIP/vgw1-00000040
[Nov 25 21:05:54] NOTICE[14686]: app_chanspy.c:479 start_spying: Attaching SIP/143-00000042 to SIP/vgw1-00000040
[Nov 25 21:05:54] NOTICE[14686]: app_chanspy.c:479 start_spying: Attaching SIP/143-00000042 to SIP/111-0000003f
Comments:By: Jeremy Kister (jkister) 2010-11-25 20:20:26.000-0600

description should read:
* 143 extenspies 111 (or 112)
 - 112's microphone is heard by 143 but not by 111
 - 111's microphone is heard by 143 and *112*
By: Jeremy Kister (jkister) 2010-11-25 20:58:22.000-0600

same configuration (ok, without the transport option in sip.conf) worked correctly in 1.6.2.14
By: Jeremy Kister (jkister) 2010-11-25 21:14:20.000-0600

possibly related to 17867
By: Jeremy Kister (jkister) 2010-11-25 21:20:28.000-0600

The issue is directly related to the 'w'hisper option of Extenspy.

This behavior occurs during exten => x,n,ExtenSpy(${CHAN},qw)
but does not occur without the 'w' option.
By: Leif Madsen (lmadsen) 2010-12-07 11:18:29.000-0600

Yes I have noticed this too. I used ChanSpy() the other day, and when (using your extension numbers) extension 143 whispers to 111, extension 111 could hear 112, but 112 could not hear 111 until the whispering channel (143) hung up.
By: anest (anest) 2011-01-18 06:01:52.000-0600

so, any planning to fix this bug? if so, when?
By: io123 (io123) 2011-01-24 00:48:34.000-0600

any news about this ?
By: Leif Madsen (lmadsen) 2011-01-24 14:49:40.000-0600

Your issue is in queue, please be patient, and we will get to it as time permits and developer resources become available.
By: Ivo Kirilov (ariko) 2011-02-03 05:29:42.000-0600

I confirm the same bug in version 1.8.2.3
using
exten => x,n,ExtenSpy(${CHAN},qw)
1. extension X dial number A
2. extension Y whisper to extension X, extension X could not hear number A, X and Y hearing each other
By: firstsip (firstsip) 2011-04-02 04:16:00

I confirm this bug and look forward to a fix.
Many Thanks
By: William luke (greenlightcrm) 2011-04-08 16:30:15

Just wondering if there are any rough timesscales for a fix? I realise resources are limited but just want to know if I should downgrade to 1.6 or if it'll be sorted soonish?

Many thanks
By: Malin Aldin (malin) 2011-05-03 07:12:55

Just uploaded a patch (see attachments above). Someone thought it a good idea to apply app_chanspy flags onto an audiohook, where setting the same bits meant something completely different. The bug was introduced by svn revisions 224178 (where the flags were applied to the channel instead, just as bad) and 228189. This may have caused a number of different errors, depending on which options specified to ChanSpy app, so it may be worth it to try the patch against other reported ChanSpy problems.

Please verify my patch! Run

patch -p1 < 0001-Bugfix-18382-one-way-audio-when-chanspy-activated.patch

in asterisk folder to apply it.

I have tested it with Asterisk 1.8.3.
By: Walter Doekes (wdoekes) 2011-05-03 07:39:07

I don't see the patch. Did you sign the license agreement?
By: Malin Aldin (malin) 2011-05-03 08:37:52

Yup, I signed it before I uploaded the patch. According to issue guidelines, the patch will become visible to others when the license has been "accepted". So, just wait and it should turn up soon.
By: Malin Aldin (malin) 2011-05-04 06:01:00

Since I'm not much for waiting and my license has still not been accepted (nor rejected for that matter) I have uploaded the patch again, without checking the code checkbox. It will probably disappear as soon as a bug marshal sees this, but before that happens perhaps someone is able to download it and try it out.
By: William luke (greenlightcrm) 2011-05-04 06:11:53

Many thanks for taking the time to look at this and produce a patch.

I've downloaded it now (before it disappears!) and will try it out later on this evening and let you know how I get on.

Regards
By: firstsip (firstsip) 2011-05-04 06:23:21

Nice manoeuvre and intentions! Thanks.
I'm sure someone will twitch. Me personally, I understand the philosophy of the bug and your fix, but I'm too chicken-sh1t scared to try it on my newly-into-production server. :-)
By: Grigoriy Puzankin (boroda) 2011-05-04 07:19:44

2malin:

I've patched my asterisk 1.8.3.2 and ChanSpy with whisper works now. Good job!
By: Malin Aldin (malin) 2011-05-04 07:29:18

Thanks boroda! :) And thank you for trying my patch!
By: David Vossel (dvossel) 2011-05-04 08:57:06

This looks correct, I am going to test and commit this.
By: Digium Subversion (svnbot) 2011-05-04 09:23:40

Repository: asterisk
Revision: 316644

U   branches/1.6.2/apps/app_chanspy.c

------------------------------------------------------------------------
r316644 | dvossel | 2011-05-04 09:23:40 -0500 (Wed, 04 May 2011) | 9 lines

Fixes one-way-audio when chanspy activated with the 'o' option

(closes issue ASTERISK-17029)
Reported by: jkister
Patches:
     0001-Bugfix-18382-one-way-audio-when-chanspy-activated.patch.txt uploaded by malin (license )
Tested by: firstsip, Greenlightcrm, malin, wdoekes, boroda, dvossel


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=316644
By: Digium Subversion (svnbot) 2011-05-04 09:25:04

Repository: asterisk
Revision: 316650

_U  branches/1.8/
U   branches/1.8/apps/app_chanspy.c

------------------------------------------------------------------------
r316650 | dvossel | 2011-05-04 09:25:04 -0500 (Wed, 04 May 2011) | 15 lines

Merged revisions 316644 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r316644 | dvossel | 2011-05-04 09:23:39 -0500 (Wed, 04 May 2011) | 9 lines
 
 Fixes one-way-audio when chanspy activated with the 'o' option
 
 (closes issue ASTERISK-17029)
 Reported by: jkister
 Patches:
       0001-Bugfix-18382-one-way-audio-when-chanspy-activated.patch.txt uploaded by malin (license )
 Tested by: firstsip, Greenlightcrm, malin, wdoekes, boroda, dvossel
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=316650
By: Digium Subversion (svnbot) 2011-05-04 09:26:34

Repository: asterisk
Revision: 316657

_U  trunk/
U   trunk/apps/app_chanspy.c

------------------------------------------------------------------------
r316657 | dvossel | 2011-05-04 09:26:34 -0500 (Wed, 04 May 2011) | 22 lines

Merged revisions 316650 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r316650 | dvossel | 2011-05-04 09:25:03 -0500 (Wed, 04 May 2011) | 15 lines
 
 Merged revisions 316644 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r316644 | dvossel | 2011-05-04 09:23:39 -0500 (Wed, 04 May 2011) | 9 lines
   
   Fixes one-way-audio when chanspy activated with the 'o' option
   
   (closes issue ASTERISK-17029)
   Reported by: jkister
   Patches:
         0001-Bugfix-18382-one-way-audio-when-chanspy-activated.patch.txt uploaded by malin (license )
   Tested by: firstsip, Greenlightcrm, malin, wdoekes, boroda, dvossel
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=316657