| Summary: | ASTERISK-17038: [patch] Mixmonitor does not parse file path proper if it contain a . (period) | ||
| Reporter: | Paul Belanger (pabelanger) | Labels: | |
| Date Opened: | 2010-11-27 15:48:23.000-0600 | Date Closed: | 2011-03-07 16:16:34.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_mixmonitor |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) bugfix.patch | |
| Description: | Using: /home/pabelanger/digium/asterisk/testing/trunk.295870/testsuite.localhost/tests/mixmonitor/testaudio1 as the filename to record, mixmonitor will assume anything after the period is the extension. [Nov 27 16:38:12] WARNING[22696] file.c: No such format 'localhost/tests/mixmonitor/testaudio1' ****** ADDITIONAL INFORMATION ****** I ran into this issue when working with the testsuite. | ||
| Comments: | By: Leif Madsen (lmadsen) 2010-12-07 11:24:15.000-0600 I acknowledge you sir. Two suggestions... * Look for the first period from the end for the format. * Have a separate field to specify the format that we should record in, i.e. MixMonitor(/tmp/I.am.awesome/filename,wav,...) By: Jonathan Rose (jrose) 2011-03-04 16:29:48.000-0600 I think we'll opt for the last period from the end method. We don't want to mess around too much with existing dial plans. By: Jonathan Rose (jrose) 2011-03-07 09:13:06.000-0600 Ok, turns out the problem isn't because looking for the last period from the end. The user didn't specify a file type, so the default in that case is supposed to be raw, but since there are periods in the file name, it assumes everything after the last period is the extension. So what I really have to do is make sure the last period takes place after the last slash. EDIT: Ok, good news, I created a patch which should fix this problem. Feel free to grab it from the attachments. By: Digium Subversion (svnbot) 2011-03-07 16:02:13.000-0600 Repository: asterisk Revision: 309856 U branches/1.4/apps/app_mixmonitor.c ------------------------------------------------------------------------ r309856 | jrose | 2011-03-07 16:02:13 -0600 (Mon, 07 Mar 2011) | 8 lines Bug fix for MixMonitor involving filenames with '.' not in the extension Closes issue ASTERISK-17038) Reported by: pabelanger Patches: ?\194?\160?\194?\160?\194?\160?\194?\160?\194?\160 bugfix.patch uploaded by jrose (license 1225) Tested by: jrose ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=309856 By: Digium Subversion (svnbot) 2011-03-07 16:04:45.000-0600 Repository: asterisk Revision: 309857 _U branches/1.6.2/ U branches/1.6.2/apps/app_mixmonitor.c ------------------------------------------------------------------------ r309857 | jrose | 2011-03-07 16:04:44 -0600 (Mon, 07 Mar 2011) | 15 lines Merged revisions 309856 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r309856 | jrose | 2011-03-07 16:02:12 -0600 (Mon, 07 Mar 2011) | 8 lines Bug fix for MixMonitor involving filenames with '.' not in the extension Closes issue ASTERISK-17038) Reported by: pabelanger Patches: ?\194?\160?\194?\160?\194?\160?\194?\160?\194?\160 bugfix.patch uploaded by jrose (license 1225) Tested by: jrose ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=309857 By: Digium Subversion (svnbot) 2011-03-07 16:07:26.000-0600 Repository: asterisk Revision: 309858 _U branches/1.8/ U branches/1.8/apps/app_mixmonitor.c ------------------------------------------------------------------------ r309858 | jrose | 2011-03-07 16:07:25 -0600 (Mon, 07 Mar 2011) | 22 lines Merged revisions 309857 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ................ r309857 | jrose | 2011-03-07 16:04:44 -0600 (Mon, 07 Mar 2011) | 15 lines Merged revisions 309856 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r309856 | jrose | 2011-03-07 16:02:12 -0600 (Mon, 07 Mar 2011) | 8 lines Bug fix for MixMonitor involving filenames with '.' not in the extension Closes issue ASTERISK-17038) Reported by: pabelanger Patches: ?\194?\160?\194?\160?\194?\160?\194?\160?\194?\160 bugfix.patch uploaded by jrose (license 1225) Tested by: jrose ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=309858 By: Digium Subversion (svnbot) 2011-03-07 16:16:33.000-0600 Repository: asterisk Revision: 309859 _U trunk/ U trunk/apps/app_mixmonitor.c ------------------------------------------------------------------------ r309859 | jrose | 2011-03-07 16:16:33 -0600 (Mon, 07 Mar 2011) | 29 lines Merged revisions 309858 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................ r309858 | jrose | 2011-03-07 16:07:25 -0600 (Mon, 07 Mar 2011) | 22 lines Merged revisions 309857 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ................ r309857 | jrose | 2011-03-07 16:04:44 -0600 (Mon, 07 Mar 2011) | 15 lines Merged revisions 309856 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r309856 | jrose | 2011-03-07 16:02:12 -0600 (Mon, 07 Mar 2011) | 8 lines Bug fix for MixMonitor involving filenames with '.' not in the extension Closes issue ASTERISK-17038) Reported by: pabelanger Patches: ?\194?\160?\194?\160?\194?\160?\194?\160?\194?\160 bugfix.patch uploaded by jrose (license 1225) Tested by: jrose ........ ................ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=309859 | ||