[Home]

Summary:ASTERISK-17083: [patch] leak in meetme
Reporter:Clod Patry (junky)Labels:
Date Opened:2010-12-09 02:10:20.000-0600Date Closed:2011-01-29 12:10:36.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) meetme_leak_trunk.diff
( 1) meetme_leak.diff
Description:While testing the newest 1.6.2.15, I realized there was a mem leak.

When a user join a meetme conf.
when they leave the conf, after the unlink, the unref is never done, resulting in a memory leak.

****** ADDITIONAL INFORMATION ******

That leak was still a problem in previous 1.6.2 (like .13)

Trunk Rev 297910 has the same issue as well, see the patch (meetme_leak_trunk.diff)


Btw, 1.6.2.15 in Product Version is missing.
Comments:By: Leif Madsen (lmadsen) 2010-12-16 09:46:44.000-0600

If you can get someone to review this, it'd be great if you could just commit it. Thanks!
By: David Vossel (dvossel) 2010-12-23 14:47:22.000-0600

That patch looks like it should cause a crash.  7 or 8 lines below were the unref is occurring we attempt to access user->jointime.
By: Ronald Chan (loloski) 2011-01-21 05:46:07.000-0600

any progress on this? thanks
By: Leif Madsen (lmadsen) 2011-01-21 08:28:17.000-0600

Any progress would be noted here in the issue tracker. It has been assigned to a developer and progress will happen as time and resources permit.
By: Digium Subversion (svnbot) 2011-01-29 10:26:59.000-0600

Repository: asterisk
Revision: 304726

U   branches/1.6.2/apps/app_meetme.c

------------------------------------------------------------------------
r304726 | seanbright | 2011-01-29 10:26:59 -0600 (Sat, 29 Jan 2011) | 9 lines

Fix user reference leak in MeetMe.

We were unlinking the user from the conferences user container, but not
decrementing the reference count of the user as well, resulting in a leak.

(closes issue ASTERISK-17083)
Reported by: junky
Tested by: seanbright

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=304726
By: Digium Subversion (svnbot) 2011-01-29 10:28:28.000-0600

Repository: asterisk
Revision: 304727

_U  branches/1.8/
U   branches/1.8/apps/app_meetme.c

------------------------------------------------------------------------
r304727 | seanbright | 2011-01-29 10:28:28 -0600 (Sat, 29 Jan 2011) | 16 lines

Merged revisions 304726 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r304726 | seanbright | 2011-01-29 11:26:57 -0500 (Sat, 29 Jan 2011) | 9 lines
 
 Fix user reference leak in MeetMe.
 
 We were unlinking the user from the conferences user container, but not
 decrementing the reference count of the user as well, resulting in a leak.
 
 (closes issue ASTERISK-17083)
 Reported by: junky
 Tested by: seanbright
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=304727
By: Digium Subversion (svnbot) 2011-01-29 10:31:18.000-0600

Repository: asterisk
Revision: 304728

_U  trunk/
U   trunk/apps/app_meetme.c

------------------------------------------------------------------------
r304728 | seanbright | 2011-01-29 10:31:18 -0600 (Sat, 29 Jan 2011) | 23 lines

Merged revisions 304727 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r304727 | seanbright | 2011-01-29 11:28:27 -0500 (Sat, 29 Jan 2011) | 16 lines
 
 Merged revisions 304726 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r304726 | seanbright | 2011-01-29 11:26:57 -0500 (Sat, 29 Jan 2011) | 9 lines
   
   Fix user reference leak in MeetMe.
   
   We were unlinking the user from the conferences user container, but not
   decrementing the reference count of the user as well, resulting in a leak.
   
   (closes issue ASTERISK-17083)
   Reported by: junky
   Tested by: seanbright
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=304728
By: Digium Subversion (svnbot) 2011-01-29 12:08:15.000-0600

Repository: asterisk
Revision: 304776

U   branches/1.6.2/apps/app_meetme.c

------------------------------------------------------------------------
r304776 | seanbright | 2011-01-29 12:08:14 -0600 (Sat, 29 Jan 2011) | 15 lines

If we fail to allocate our announcement objects, make sure we don't leak objects.

The majority of this patch was committed already in r304726 and r304729.

(issue ASTERISK-16886)
Reported by: kenji

(issue ASTERISK-17083)
Reported by: junky

(closes issue ASTERISK-16992)
Reported by: kobaz
Patches:
     meetme-refs.diff uploaded by kobaz (license 834)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=304776
By: Digium Subversion (svnbot) 2011-01-29 12:09:38.000-0600

Repository: asterisk
Revision: 304777

_U  branches/1.8/
U   branches/1.8/apps/app_meetme.c

------------------------------------------------------------------------
r304777 | seanbright | 2011-01-29 12:09:37 -0600 (Sat, 29 Jan 2011) | 22 lines

Merged revisions 304776 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r304776 | seanbright | 2011-01-29 13:08:14 -0500 (Sat, 29 Jan 2011) | 15 lines
 
 If we fail to allocate our announcement objects, make sure we don't leak objects.
 
 The majority of this patch was committed already in r304726 and r304729.
 
 (issue ASTERISK-16886)
 Reported by: kenji
 
 (issue ASTERISK-17083)
 Reported by: junky
 
 (closes issue ASTERISK-16992)
 Reported by: kobaz
 Patches:
       meetme-refs.diff uploaded by kobaz (license 834)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=304777
By: Digium Subversion (svnbot) 2011-01-29 12:10:36.000-0600

Repository: asterisk
Revision: 304778

_U  trunk/
U   trunk/apps/app_meetme.c

------------------------------------------------------------------------
r304778 | seanbright | 2011-01-29 12:10:35 -0600 (Sat, 29 Jan 2011) | 29 lines

Merged revisions 304777 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r304777 | seanbright | 2011-01-29 13:09:37 -0500 (Sat, 29 Jan 2011) | 22 lines
 
 Merged revisions 304776 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r304776 | seanbright | 2011-01-29 13:08:14 -0500 (Sat, 29 Jan 2011) | 15 lines
   
   If we fail to allocate our announcement objects, make sure we don't leak objects.
   
   The majority of this patch was committed already in r304726 and r304729.
   
   (issue ASTERISK-16886)
   Reported by: kenji
   
   (issue ASTERISK-17083)
   Reported by: junky
   
   (closes issue ASTERISK-16992)
   Reported by: kobaz
   Patches:
         meetme-refs.diff uploaded by kobaz (license 834)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=304778