[Home]

Summary:ASTERISK-17096: [patch] cel.conf mentions USER_EVENT when it should be USER_DEFINED
Reporter:Josep Casals C (joscas)Labels:
Date Opened:2010-12-11 14:01:07.000-0600Date Closed:2011-01-03 16:11:14.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:CDR/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cel.conf.sample.diff
Description:The channel event logger doesn't recognize an event called USER_EVENT

****** ADDITIONAL INFORMATION ******

This is the list of events in the sample cel.conf:
____________
; Event Tracking
;
; Use the 'events' keyword to specify the list of events which you want to be
; raised when they occur.  This is a comma separated list of the values in the
; table below.
;
; Accepted values: A comma separated list of one or more of the following:
;  ALL              -- Generate entries on all events
;  CHAN_START       -- The time a channel was created
;  CHAN_END         -- The time a channel was terminated
;  ANSWER           -- The time a channel was answered (ie, phone taken off-hook)
;  HANGUP           -- The time at which a hangup occurred
;  CONF_ENTER       -- The time a channel was connected into a conference room
;  CONF_EXIT        -- The time a channel was removed from a conference room
;  CONF_START       -- The time the first person enters a conference room
;  CONF_END         -- The time the last person left a conference room (and
;                      turned out the lights?)
;  APP_START        -- The time a tracked application was started
;  APP_END          -- the time a tracked application ended
;  PARK_START       -- The time a call was parked
;  PARK_END         -- Unpark event
;  BRIDGE_START     -- The time a bridge is started
;  BRIDGE_END       -- The time a bridge is ended
;  3WAY_START       -- When a 3-way conference starts (usually via attended xfer)
;  3WAY_END         -- When one or all exit a 3-way conference
;  BLINDTRANSFER    -- When a blind transfer is initiated
;  ATTENDEDTRANSFER -- When an attended transfer is initiated
;  TRANSFER         -- Generic transfer initiated; not used yet...?
;  HOOKFLASH        -- So far, when a hookflash event occurs on a DAHDI
;                      interface
;  USER_EVENT       -- Triggered from the dialplan, and has a name given by the
;                      user
;
; Default value: none
;                (Track no events)
_____________________

But cel.c uses this set of events:

________________
/*!
* \brief Map of ast_cel_event_type to strings
*/
static const char * const cel_event_types[CEL_MAX_EVENT_IDS] = {
       [0]                        = "ALL",
       [AST_CEL_CHANNEL_START]    = "CHAN_START",
       [AST_CEL_CHANNEL_END]      = "CHAN_END",
       [AST_CEL_ANSWER]           = "ANSWER",
       [AST_CEL_HANGUP]           = "HANGUP",
       [AST_CEL_APP_START]        = "APP_START",
       [AST_CEL_APP_END]          = "APP_END",
       [AST_CEL_BRIDGE_START]     = "BRIDGE_START",
       [AST_CEL_BRIDGE_END]       = "BRIDGE_END",
       [AST_CEL_BRIDGE_UPDATE]    = "BRIDGE_UPDATE",
       [AST_CEL_CONF_START]       = "CONF_START",
       [AST_CEL_CONF_END]         = "CONF_END",
       [AST_CEL_PARK_START]       = "PARK_START",
       [AST_CEL_PARK_END]         = "PARK_END",
       [AST_CEL_TRANSFER]         = "TRANSFER",
       [AST_CEL_USER_DEFINED]     = "USER_DEFINED",
       [AST_CEL_CONF_ENTER]       = "CONF_ENTER",
       [AST_CEL_CONF_EXIT]        = "CONF_EXIT",
       [AST_CEL_BLINDTRANSFER]    = "BLINDTRANSFER",
       [AST_CEL_ATTENDEDTRANSFER] = "ATTENDEDTRANSFER",
       [AST_CEL_PICKUP]           = "PICKUP",
       [AST_CEL_FORWARD]          = "FORWARD",
       [AST_CEL_3WAY_START]       = "3WAY_START",
       [AST_CEL_3WAY_END]         = "3WAY_END",
       [AST_CEL_HOOKFLASH]        = "HOOKFLASH",
       [AST_CEL_LINKEDID_END]     = "LINKEDID_END",
};
Comments:By: Andrew Latham (lathama) 2010-12-17 10:59:01.000-0600

Does that answer your request?  If so please test and verify, then post your results.
By: Josep Casals C (joscas) 2010-12-20 04:47:33.000-0600

The patch does correct the problem. Thanks.
By: Andrew Latham (lathama) 2010-12-20 06:04:55.000-0600

O great Bug Marshalls of the sky, a few clicks please for this documentation update?
By: Digium Subversion (svnbot) 2010-12-20 18:44:09.000-0600

Repository: asterisk
Revision: 299312

U   branches/1.8/configs/cel.conf.sample

------------------------------------------------------------------------
r299312 | pabelanger | 2010-12-20 18:44:08 -0600 (Mon, 20 Dec 2010) | 8 lines

Correct typo with USER_DEFINED event.

(closes issue ASTERISK-17096)
Reported by: joscas
Patches:
     cel.conf.sample.diff uploaded by lathama (license 1028)
     Tested by: lathama, joscas

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=299312
By: Digium Subversion (svnbot) 2010-12-20 18:45:41.000-0600

Repository: asterisk
Revision: 299313

_U  trunk/
U   trunk/configs/cel.conf.sample

------------------------------------------------------------------------
r299313 | pabelanger | 2010-12-20 18:45:41 -0600 (Mon, 20 Dec 2010) | 15 lines

Merged revisions 299312 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r299312 | pabelanger | 2010-12-20 19:44:08 -0500 (Mon, 20 Dec 2010) | 8 lines
 
 Correct typo with USER_DEFINED event.
 
 (closes issue ASTERISK-17096)
 Reported by: joscas
 Patches:
       cel.conf.sample.diff uploaded by lathama (license 1028)
       Tested by: lathama, joscas
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=299313