[Home]

Summary:ASTERISK-17135: SIP autocreated peers crash asterisk on call
Reporter:Kirill Katsnelson (kkm)Labels:
Date Opened:2010-12-20 15:04:33.000-0600Date Closed:2010-12-20 15:40:33.000-0600
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:So I am the only person in the world using autopeers, out in the cold alone. Scary. Proud but scared.

Any call to any SIP autopeer crashes, by way of either Dial() or Queue().

Note that a call on other direction, to a static peer, won't crash asterisk.

****** STEPS TO REPRODUCE ******

1. _X. => Dial(SIP/${EXTEN})
2. enable autopeers in sip.conf: autocreatepeer=yes
3. Register an autopeer not among static peers.
4. Call it.

Program terminated with signal 11, Segmentation fault.
#0  0x0000000000453b26 in ast_cc_copy_config_params (dest=0xb988e0, src=0x0) at ccss.c:710
710             *dest = *src;
(gdb) bt
#0  0x0000000000453b26 in ast_cc_copy_config_params (dest=0xb988e0, src=0x0) at ccss.c:710
#1  0x00007ff5663e8305 in create_addr_from_peer (dialog=0xb9d068, peer=0xac9178) at chan_sip.c:4917

****** ADDITIONAL INFORMATION ******

This line in create_addr_from_peer() (and the whole CCSS thing) is new in 1.8

ast_cc_copy_config_params(dialog->cc_params, peer->cc_params);

peer->cc_params is obviously NULL for an autopeer. D-oh.

I do not currently understand how to fix it.
Comments:By: Digium Subversion (svnbot) 2010-12-20 15:38:31.000-0600

Repository: asterisk
Revision: 299248

U   branches/1.8/channels/chan_sip.c

------------------------------------------------------------------------
r299248 | mmichelson | 2010-12-20 15:38:31 -0600 (Mon, 20 Dec 2010) | 20 lines

Fix a couple of CCSS issues.

* Make sure to allocate a cc_params structure
 when creating autopeers.

* Use sip_uri_cmp when retrieving SIP CC agents
 and monitors in case parameters appear in the
 URI.

(closes issue ASTERISK-17135)
Reported by: kkm

(closes issue ASTERISK-16987)
Reported by: GeorgeKonopacki
Patches:
     18338.diff uploaded by mmichelson (license 60)
Tested by: GeorgeKonopacki



------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=299248
By: Digium Subversion (svnbot) 2010-12-20 15:40:33.000-0600

Repository: asterisk
Revision: 299249

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r299249 | mmichelson | 2010-12-20 15:40:33 -0600 (Mon, 20 Dec 2010) | 25 lines

Merged revisions 299248 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r299248 | mmichelson | 2010-12-20 15:38:30 -0600 (Mon, 20 Dec 2010) | 20 lines
 
 Fix a couple of CCSS issues.
 
 * Make sure to allocate a cc_params structure
   when creating autopeers.
 
 * Use sip_uri_cmp when retrieving SIP CC agents
   and monitors in case parameters appear in the
   URI.
 
 (closes issue ASTERISK-17135)
 Reported by: kkm
 
 (closes issue ASTERISK-16987)
 Reported by: GeorgeKonopacki
 Patches:
       18338.diff uploaded by mmichelson (license 60)
 Tested by: GeorgeKonopacki
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=299249