[Home]

Summary:ASTERISK-17140: [patch] chan_dahdi inserts empty COLP
Reporter:Birger "WIMPy" Harzenetter (wimpy)Labels:
Date Opened:2010-12-21 01:01:16.000-0600Date Closed:2010-12-21 20:12:03.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue18508_trunk.patch
Description:As far as I can tell, chan_dahdi always inserts a connected party IE when you call from one dahdi channel to another dahdi channel, even if no such information was received on the 2nd channel.

This clears the display of many phones.

****** ADDITIONAL INFORMATION ******

I set the Reproducibility to sometimes as no CLOP is inserted when calling an IVR extension. But it always is in the described scenario.
Comments:By: Birger "WIMPy" Harzenetter (wimpy) 2010-12-21 19:43:51.000-0600

Yes, the patch fixes the issue.
Now it only forwards what is received.

Thank you for the quick fix.
By: Richard Mudgett (rmudgett) 2010-12-21 19:52:39.000-0600

Fixed leftover artifact from before the valid flag was added.

Also updated all of the channel's caller id information with the new connected line information instead of just the string parts.
By: Digium Subversion (svnbot) 2010-12-21 20:10:40.000-0600

Repository: asterisk
Revision: 299405

U   branches/1.8/channels/sig_pri.c

------------------------------------------------------------------------
r299405 | rmudgett | 2010-12-21 20:10:40 -0600 (Tue, 21 Dec 2010) | 17 lines

Chan_dahdi sends an empty COLP on the bridged channel.

Chan_dahdi always inserts a connected party IE when you call from one
dahdi channel to another dahdi channel, even if no such information was
received on the 2nd channel.  This clears the display of many phones.

* Removed leftover artifact from before the valid flag was added.

* Updated all of the channel's caller id information with the new
connected line information instead of just the string parts.

(closes issue ASTERISK-17140)
Reported by: wimpy
Patches:
     issue18508_trunk.patch uploaded by rmudgett (license 664)
Tested by: wimpy, rmudgett

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=299405
By: Digium Subversion (svnbot) 2010-12-21 20:12:02.000-0600

Repository: asterisk
Revision: 299406

_U  trunk/
U   trunk/channels/sig_pri.c

------------------------------------------------------------------------
r299406 | rmudgett | 2010-12-21 20:12:02 -0600 (Tue, 21 Dec 2010) | 24 lines

Merged revisions 299405 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r299405 | rmudgett | 2010-12-21 20:10:39 -0600 (Tue, 21 Dec 2010) | 17 lines
 
 Chan_dahdi sends an empty COLP on the bridged channel.
 
 Chan_dahdi always inserts a connected party IE when you call from one
 dahdi channel to another dahdi channel, even if no such information was
 received on the 2nd channel.  This clears the display of many phones.
 
 * Removed leftover artifact from before the valid flag was added.
 
 * Updated all of the channel's caller id information with the new
 connected line information instead of just the string parts.
 
 (closes issue ASTERISK-17140)
 Reported by: wimpy
 Patches:
       issue18508_trunk.patch uploaded by rmudgett (license 664)
 Tested by: wimpy, rmudgett
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=299406