Summary:	ASTERISK-17167: [patch] MySQL table definitions are broken (wrong commas and a wrong name)
Reporter:	Sebastian Denz (denzs)	Labels:
Date Opened:	2010-12-27 06:21:40.000-0600	Date Closed:	2011-05-05 18:16:18
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Documentation
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) meetme.sql.diff ( 1) meetme.sql.svndiff ( 2) new_meetme.sql.diff ( 3) queue_log.sql.diff ( 4) queue_log.sql.svndiff ( 5) sipfriends.sql.diff ( 6) sipfriends.sql.svndiff
Description:	In contrib/realtime/mysql/queue_log.sql the column "datetime" is referenced as index, but the correct name is "time". In contrib/realtime/mysql/sipfriends.sql there is a comma in the last line inside of the brackets. In contrib/realtime/mysql/meetme.sql there is a comma in the last line inside of the brackets.
Comments:	By: Sebastian Denz (denzs) 2010-12-27 06:26:00.000-0600 added 3 tiny patches which made the sqldumps appliable for me By: Sebastian Denz (denzs) 2010-12-27 10:05:16.000-0600 attached new version of meetme.sql patch By: Paul Belanger (pabelanger) 2010-12-27 12:14:44.000-0600 No need for individual patches (see below). --- Please use `svn diff` on all your patches. Patches which include alternate formatting are almost certainly going to be thrown out or ignored. By: Sebastian Denz (denzs) 2010-12-28 04:26:00.000-0600 added patches in "svn diff" format. i also added the column dtmfmode to the sipfriends table i think this column is required isnt it? By: Sebastian Denz (denzs) 2010-12-28 08:15:57.000-0600 as far as i can rate, i think the meetme.sql.svndiff and queue_log.sql.svndiff file should be good. but iam still unsure about the sipfriends table... after adding dtmfmode i still miss columns like nat, directmedia the sip_devices template from http://www.voip-info.org/wiki/view/Asterisk+RealTime+Sip has some other interesting columns too...like sendrpid session-expires session-minse session-refresher session-timers videosupport permit deny ... and some more i would prefer to have all possible sip.conf-settings in the template what do you think?! if desired i will merge the different templates and try to straighten it a bit ;) By: Digium Subversion (svnbot) 2011-05-05 18:15:54 Repository: asterisk Revision: 317486 U   branches/1.8/contrib/realtime/mysql/queue_log.sql U   branches/1.8/contrib/realtime/mysql/sipfriends.sql ------------------------------------------------------------------------ r317486 | russell | 2011-05-05 18:15:54 -0500 (Thu, 05 May 2011) | 9 lines Fix some more realtime MySQL schema issues. (closes issue ASTERISK-17167) Reported by: denzs Patches:      sipfriends.sql.svndiff uploaded by denzs (license 1182)      queue_log.sql.svndiff uploaded by denzs (license 1182)      meetme.sql.svndiff uploaded by denzs (license 1182) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=317486 By: Digium Subversion (svnbot) 2011-05-05 18:16:17 Repository: asterisk Revision: 317487 _U  trunk/ U   trunk/contrib/realtime/mysql/queue_log.sql U   trunk/contrib/realtime/mysql/sipfriends.sql ------------------------------------------------------------------------ r317487 | russell | 2011-05-05 18:16:17 -0500 (Thu, 05 May 2011) | 16 lines Merged revisions 317486 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........  r317486 | russell | 2011-05-05 18:15:53 -0500 (Thu, 05 May 2011) | 9 lines    Fix some more realtime MySQL schema issues.    (closes issue ASTERISK-17167)  Reported by: denzs  Patches:        sipfriends.sql.svndiff uploaded by denzs (license 1182)        queue_log.sql.svndiff uploaded by denzs (license 1182)        meetme.sql.svndiff uploaded by denzs (license 1182) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=317487