[Home]

Summary:ASTERISK-17200: handle_request_info uses uninitialized string buffer
Reporter:zvision (zvision)Labels:
Date Opened:2011-01-04 06:22:39.000-0600Date Closed:2011-08-23 23:45:21
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue_17200.diff
Description:I receive DTMFs from Cirpack in a SIP INFO message in the following format:

INFO sip:x@x SIP/2.0
...
User-Agent: Cirpack/v4.42q (gw_sip)
Content-Type: application/dtmf
...
Content-Length: 1

1

The Content-Type is not recognized by Asterisk as DTMF, but this is a minor problem. At the end of handle_request_info function there is a line to print
a log line:

ast_log(LOG_WARNING, "Unable to parse INFO message from %s. Content %s\n", p->callid, buf);

If the Content-Type does not match any IFs above this line, contents of the buf variable is uninitialized and the Asterisk prints garbage reading uninitialized stack memory.

****** ADDITIONAL INFORMATION ******

The bug still exists in the SVN 1.4 branch.
Comments:By: David Vossel (dvossel) 2011-07-20 16:45:34.233-0500

This patch fixes the uninitialized memory.