Summary: | ASTERISK-17286: [patch] Cdr_syslog loses configuration on reload | ||
Reporter: | Eric Negaard (enegaard) | Labels: | |
Date Opened: | 2011-01-26 02:57:42.000-0600 | Date Closed: | 2011-05-05 18:02:14 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | CDR/NewFeature |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) issue18679_seanbright.patch ( 1) issue18679.patch | |
Description: | If asterisk is reloaded and the cdr_syslog configuration file has not been changed, the syslog "sink" configuration is lost and no further syslog records are written. | ||
Comments: | By: Eric Negaard (enegaard) 2011-01-26 03:04:09.000-0600 The attached patch resolves the problem. By: Sean Bright (seanbright) 2011-01-26 14:32:31.000-0600 The newly attached patch will also handle the case that load_config() returns a -1, which would happen if the new configuration file was invalid or didn't include any sinks. Can you test and/or review? By: Eric Negaard (enegaard) 2011-01-27 23:54:06.000-0600 @seanbright I have installed your patch - it looks correct, and works so far (also after a reload). By: Leif Madsen (lmadsen) 2011-02-07 14:23:44.000-0600 Marked as Ready For Review after someone tested and reports the patch as working. By: Digium Subversion (svnbot) 2011-05-05 18:00:57 Repository: asterisk Revision: 317480 U branches/1.8/cdr/cdr_syslog.c ------------------------------------------------------------------------ r317480 | russell | 2011-05-05 18:00:56 -0500 (Thu, 05 May 2011) | 8 lines Don't lose cdr_syslog config on a reload. (closes issue ASTERISK-17286) Reported by: enegaard Patches: issue18679_seanbright.patch uploaded by seanbright (license 71) Tested by: enegaard ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=317480 By: Digium Subversion (svnbot) 2011-05-05 18:02:13 Repository: asterisk Revision: 317481 _U trunk/ U trunk/cdr/cdr_syslog.c ------------------------------------------------------------------------ r317481 | russell | 2011-05-05 18:02:13 -0500 (Thu, 05 May 2011) | 15 lines Merged revisions 317480 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........ r317480 | russell | 2011-05-05 18:00:55 -0500 (Thu, 05 May 2011) | 8 lines Don't lose cdr_syslog config on a reload. (closes issue ASTERISK-17286) Reported by: enegaard Patches: issue18679_seanbright.patch uploaded by seanbright (license 71) Tested by: enegaard ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=317481 |