[Home]

Summary:ASTERISK-17324: [regression] Implicit declaration of copy yields broken app_voicemail when building with IMAP support
Reporter:Kerin Millar (kerframil)Labels:
Date Opened:2011-01-31 15:24:49.000-0600Date Closed:2011-02-09 14:49:55.000-0600
Priority:BlockerRegression?Yes
Status:Closed/CompleteComponents:Applications/app_voicemail/IMAP
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:While upgrading from 1.4.37 to 1.4.39.1, I noticed the following anomaly during compilation:

app_voicemail.c: In function 'vm_forwardoptions':
app_voicemail.c:5209: warning: implicit declaration of function 'copy'

I then observed that app_voicemail.so could not be loaded into the resulting instance of asterisk:

[Jan 31 07:42:16] WARNING[30718]: loader.c:382 load_dynamic_module:
Error loading module 'app_voicemail.so':
/usr/lib64/asterisk/modules/app_voicemail.so: undefined symbol: copy

This apparent regression was introduced by r295200 in the 1.4 branch (committed by jpeeler). In particular, lines ASTERISK-5071 and ASTERISK-5074 seem to be to blame. They both call upon copy(), something which - as far as I can tell - is defined alternately in imap/mail.h (from c-client) and in app_voicemail.c itself if IMAP_STORAGE is _not_ defined, so I suppose that's where the problem stems from. I don't know how to fix this in the appropriate fashion so, for now, I opted to revert the changes that trigger this problem.

****** ADDITIONAL INFORMATION ******

I build asterisk using --with-imap=system and have c-client-2007e installed. The issue does not occur when building without imap support. Asterisk releases preceding r295200 are unaffected.
Comments:By: Leif Madsen (lmadsen) 2011-02-07 13:56:41.000-0600

http://svnview.digium.com/svn/asterisk?view=revision&revision=295200
By: Digium Subversion (svnbot) 2011-02-08 13:18:51.000-0600

Repository: asterisk
Revision: 306960

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r306960 | jpeeler | 2011-02-08 13:18:50 -0600 (Tue, 08 Feb 2011) | 9 lines

Backup file storing message duration is not used with IMAP_STORAGE, remove code.

The message duration is stored in the body of the email when using IMAP_STORAGE,
so nothing needs to happen with the backup file.

(closes issue ASTERISK-17324)
Reported by: kerframil


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=306960
By: Digium Subversion (svnbot) 2011-02-08 13:25:11.000-0600

Repository: asterisk
Revision: 306961

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_voicemail.c

------------------------------------------------------------------------
r306961 | jpeeler | 2011-02-08 13:25:11 -0600 (Tue, 08 Feb 2011) | 15 lines

Merged revisions 306960 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r306960 | jpeeler | 2011-02-08 13:18:50 -0600 (Tue, 08 Feb 2011) | 9 lines
 
 Backup file storing message duration is not used with IMAP_STORAGE, remove code.
 
 The message duration is stored in the body of the email when using IMAP_STORAGE,
 so nothing needs to happen with the backup file.
 
 (closes issue ASTERISK-17324)
 Reported by: kerframil
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=306961
By: Digium Subversion (svnbot) 2011-02-08 13:25:39.000-0600

Repository: asterisk
Revision: 306962

_U  branches/1.8/
U   branches/1.8/apps/app_voicemail.c

------------------------------------------------------------------------
r306962 | jpeeler | 2011-02-08 13:25:38 -0600 (Tue, 08 Feb 2011) | 22 lines

Merged revisions 306961 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r306961 | jpeeler | 2011-02-08 13:25:10 -0600 (Tue, 08 Feb 2011) | 15 lines
 
 Merged revisions 306960 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r306960 | jpeeler | 2011-02-08 13:18:50 -0600 (Tue, 08 Feb 2011) | 9 lines
   
   Backup file storing message duration is not used with IMAP_STORAGE, remove code.
   
   The message duration is stored in the body of the email when using IMAP_STORAGE,
   so nothing needs to happen with the backup file.
   
   (closes issue ASTERISK-17324)
   Reported by: kerframil
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=306962
By: Digium Subversion (svnbot) 2011-02-08 13:26:06.000-0600

Repository: asterisk
Revision: 306963

_U  trunk/
U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r306963 | jpeeler | 2011-02-08 13:26:05 -0600 (Tue, 08 Feb 2011) | 29 lines

Merged revisions 306962 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r306962 | jpeeler | 2011-02-08 13:25:38 -0600 (Tue, 08 Feb 2011) | 22 lines
 
 Merged revisions 306961 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r306961 | jpeeler | 2011-02-08 13:25:10 -0600 (Tue, 08 Feb 2011) | 15 lines
   
   Merged revisions 306960 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r306960 | jpeeler | 2011-02-08 13:18:50 -0600 (Tue, 08 Feb 2011) | 9 lines
     
     Backup file storing message duration is not used with IMAP_STORAGE, remove code.
     
     The message duration is stored in the body of the email when using IMAP_STORAGE,
     so nothing needs to happen with the backup file.
     
     (closes issue ASTERISK-17324)
     Reported by: kerframil
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=306963