[Home]

Summary:ASTERISK-17397: features reload does not clear old configuration and always include 700 on parkedcalls
Reporter:Mikael Carlsson (mickecarlsson)Labels:
Date Opened:2011-02-13 12:34:07.000-0600Date Closed:2011-04-07 08:42:15
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Features/Parking
Versions:1.8.2 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:features.conf look like this
[general]
parkext=200

Stop and start Asterisk, then type  dialplan show parkedcalls
the output is this:
[ Context 'parkedcalls' created by 'features' ]
 '200' =>          1. Park()  [features]
 '700' =>          1. Park()  [features]

Where does 700 come from????

Now, edit features.conf to look like this:
[general]
parkext=200

Do a feature reload, the output is like this:
 == Parsing '/etc/asterisk/features.conf':   == Found
   -- Added extension '300' priority 1 to parkedcalls

Now, do a dialplan show parkedcalls, the output is this:
[ Context 'parkedcalls' created by 'features' ]
 '200' =>          1. Park()  [features]
 '300' =>          1. Park()  [features]
 '700' =>          1. Park()  [features]

The old entries does not clear, and that dreaded 700 is still there.


Comments:By: Mikael Carlsson (mickecarlsson) 2011-02-14 00:03:54.000-0600

I noted a typo in the text, the second edit should read:
Now, edit features.conf to look like this:
[general]
parkext=300
**********************'

After that edit, if I type dialplan show 200@from-internal (my context in FreePBX) I get:
[ Included context 'parkedcalls' created by 'features' ]
 '200' =>          1. Park()                                     [features]

But that entry does not exists in the config file anymore.

300 is there as well as all the others:
dialplan show parkedcalls
[ Context 'parkedcalls' created by 'features' ]
 '200' =>          1. Park()                                     [features]
 '300' =>          1. Park()                                     [features]
 '70' =>           1. Park()                                     [features]
 '700' =>          1. Park()                                     [features]
By: Philippe Lindheimer (p_lindheimer) 2011-02-16 10:33:55.000-0600

confirmed, New configuration, set parking lot to 70, 'module reload' shows 70 and 700, restart Asterisk, still shows both. Checked all feature*.conf files (e.g. features.conf and all included) no setting of 700. So the default of 700 is always retained despite configuration.
By: Leif Madsen (lmadsen) 2011-02-16 15:56:23.000-0600

Confirmed and reproduced on my box. It is changed in the 'features show' output, but when doing the 'dialplan show parkedcalls' it simply adds to the dialplan without clearing the existing extensions.
By: Digium Subversion (svnbot) 2011-04-07 08:23:04

Repository: asterisk
Revision: 313047

U   branches/1.6.2/main/features.c

------------------------------------------------------------------------
r313047 | jrose | 2011-04-07 08:23:02 -0500 (Thu, 07 Apr 2011) | 9 lines

Makes parking lots clear and rebuild properly when features reload is invoked from CLI

Before, default parkinglot in context parkedcalls with ext 700 would always be present and when reload was invoked, the previous parkinglots would not be cleared.

(closes issue ASTERISK-17397)
Reported by: mickecarlsson

Review: https://reviewboard.asterisk.org/r/1161/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=313047
By: Digium Subversion (svnbot) 2011-04-07 08:35:34

Repository: asterisk
Revision: 313048

_U  branches/1.8/
U   branches/1.8/main/features.c

------------------------------------------------------------------------
r313048 | jrose | 2011-04-07 08:35:34 -0500 (Thu, 07 Apr 2011) | 16 lines

Merged revisions 313047 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r313047 | jrose | 2011-04-07 08:23:01 -0500 (Thu, 07 Apr 2011) | 9 lines
 
 Makes parking lots clear and rebuild properly when features reload is invoked from CLI
 
 Before, default parkinglot in context parkedcalls with ext 700 would always be present and when reload was invoked, the previous parkinglots would not be cleared.
 
 (closes issue ASTERISK-17397)
 Reported by: mickecarlsson
 
 Review: https://reviewboard.asterisk.org/r/1161/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=313048
By: Digium Subversion (svnbot) 2011-04-07 08:42:14

Repository: asterisk
Revision: 313049

_U  trunk/
U   trunk/main/features.c

------------------------------------------------------------------------
r313049 | jrose | 2011-04-07 08:42:14 -0500 (Thu, 07 Apr 2011) | 23 lines

Merged revisions 313048 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r313048 | jrose | 2011-04-07 08:35:33 -0500 (Thu, 07 Apr 2011) | 16 lines
 
 Merged revisions 313047 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r313047 | jrose | 2011-04-07 08:23:01 -0500 (Thu, 07 Apr 2011) | 9 lines
   
   Makes parking lots clear and rebuild properly when features reload is invoked from CLI
   
   Before, default parkinglot in context parkedcalls with ext 700 would always be present and when reload was invoked, the previous parkinglots would not be cleared.
   
   (closes issue ASTERISK-17397)
   Reported by: mickecarlsson
   
   Review: https://reviewboard.asterisk.org/r/1161/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=313049