Summary:	ASTERISK-17428: [patch] Allow "Comedian Mail" branding to be removed
Reporter:	John Covert (jcovert)	Labels:
Date Opened:	2011-02-17 19:06:48.000-0600	Date Closed:	2017-02-14 17:22:42.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_voicemail.c.patch ( 1) voicemail_custom_intro_1.8.diff ( 2) voicemail_custom_intro_trunk.diff ( 3) voicemail.conf.sample.2.patch ( 4) voicemail.conf.sample.patch
Description:	Some people have no sensahuma. I have a client about to deploy several hundred Asterisk Voicemail systems, but the boss thinks that "Comedian Mail" is unprofessional. I have made the vm-login and vm-newuser prompts settable in voicemail.conf. This allowed us to change vm-login to just "Mailbox?" and vm-newuser to "Welcome. First I will guide you..." Patches supplied.
Comments:	By: Andrew Latham (lathama) 2011-02-18 11:51:14.000-0600 Looks nice.  Remember there is another history to the comedian mail. If we can get some testers and update the config patch to note the defaults I can commit. By: John Covert (jcovert) 2011-02-18 12:34:10.000-0600 >update the config patch to note the defaults There seems to be no real consensus on whether what is commented out in a config file should be the default or the changed value.  More commonly it's the changed value, which is why I made it exactly like the four lines already there. Except I misspelled "is" as "us".  So I'll fix that, and add the name of the default file for all of the customizable sounds, not just the two I added. Coming soon.  will be voicemail.conf.sample.2.patch By: Andrew Latham (lathama) 2011-02-18 12:38:57.000-0600 I would find some way to mention the filenames in the config file.  They are in the C file but not all users look there. By: John Covert (jcovert) 2011-02-18 12:59:15.000-0600 The filenames happen to be the same as the variable names, but I've mentioned them just the same and corrected some errors and omissions along the way. By: John Covert (jcovert) 2011-04-06 17:25:35 ping By: Paul Belanger (pabelanger) 2011-04-06 18:23:28 I'd suggest merging the various patches into one.  This make it easy for somebody to test and merge.  Additionally, 'svn diff' is the preferred patch. By: Andrew Latham (lathama) 2011-04-07 06:58:30 Combined patch uploaded for trunk By: Andrew Latham (lathama) 2011-04-07 07:06:26 Combined patch uploaded for 1.8 By: Andrew Latham (lathama) 2011-04-07 14:02:14 Compiled for an unrelated issue and found there are errors in the patches. removing By: Andrew Latham (lathama) 2011-04-07 14:53:01 voicemail_custom_intro_1.8.diff voicemail_custom_intro_trunk.diff uploaded. By: Friendly Automation (friendly-automation) 2017-02-14 17:22:43.775-0600 Change 4940 merged by zuul: app_voicemail: Allow 'Comedian Mail' branding to be overriden [https://gerrit.asterisk.org/4940|https://gerrit.asterisk.org/4940] By: Friendly Automation (friendly-automation) 2017-02-14 17:43:07.022-0600 Change 4942 merged by zuul: app_voicemail: Allow 'Comedian Mail' branding to be overriden [https://gerrit.asterisk.org/4942|https://gerrit.asterisk.org/4942] By: Friendly Automation (friendly-automation) 2017-02-14 18:03:40.244-0600 Change 4941 merged by zuul: app_voicemail: Allow 'Comedian Mail' branding to be overriden [https://gerrit.asterisk.org/4941|https://gerrit.asterisk.org/4941]