Summary:	ASTERISK-17455: The "Unlink" bridge event in channel.c
Reporter:	ujvu (ujvu)	Labels:
Date Opened:	2011-02-22 02:27:59.000-0600	Date Closed:	2011-08-08 16:25:08
Priority:	Trivial	Regression?
Status:	Closed/Complete	Components:	Core/ManagerInterface
Versions:	1.6.2.15 1.8.5.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	In doc\manager_1_1.txt (line 63): - The "Link" and "Unlink" bridge events in channel.c are now renamed to "Bridge"! But in channel.c (line 5548): manager_event(EVENT_FLAG_CALL, "Unlink",      "Channel1: %s\r\n"      "Channel2: %s\r\n"      "Uniqueid1: %s\r\n"      "Uniqueid2: %s\r\n"      "CallerID1: %s\r\n"      "CallerID2: %s\r\n",      c0->name, c1->name, c0->uniqueid, c1->uniqueid, c0->cid.cid_num, c1->cid.cid_num); channel.c (line 5622): manager_event(EVENT_FLAG_CALL, "Unlink",      "Channel1: %s\r\n"      "Channel2: %s\r\n"      "Uniqueid1: %s\r\n"      "Uniqueid2: %s\r\n"      "CallerID1: %s\r\n"      "CallerID2: %s\r\n",      c0->name, c1->name, c0->uniqueid, c1->uniqueid, c0->cid.cid_num, c1->cid.cid_num);
Comments:	By: David Woolley (davidw) 2011-03-02 09:08:12.000-0600 "Text" is the wrong severity for this, as it does break a documented API.  I'm not sure if it should be Trivial or Minor, given how long it took for this to be first found.  We currently only look for Bridge/Link, not for any Unlinks. By: Terry Wilson (twilson) 2011-08-04 17:31:28.545-0500 It looks like when oej did the AMI 1.1 patch that originally changed this behavior, that these two instances were not converted to calls to manager_bridge_event(). One of these calls has been there since 2005 and the other since 2006. The change happened in 2007. I really don't like making behavior changes to release branches, but this is *really* inconsistent. One Link event and one Unlink event were actually converted, but these two were not. Leaving things the way they are is really ugly, but then again it took 4 years for anyone to actually report it. My inclination is to leave 1.8 and earlier as-is, and change this to be more consistent in is 1.10+.