Summary:	ASTERISK-17464: [patch] sig_pri_new_ast_channel should return NULL when new_ast_channel fails to create a channel
Reporter:	cmaj (cmaj)	Labels:
Date Opened:	2011-02-23 11:37:51.000-0600	Date Closed:	2011-02-23 17:45:04.000-0600
Priority:	Critical	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_dahdi
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) patch-sig_pri-crash-possible-null-channel-pointer.diff.txt
Description:	It appears that a non-existent channel's transfercapability was trying to be set. This was during a kill -9 on a runaway box deadlocking in the TCP TLS layer (which took over a minute to die, a separate matter.) But it still looks like a bug. Patch attached. (gdb) bt #0  sig_pri_new_ast_channel (p=0x12a0900, state=<value optimized out>, ulaw=<value optimized out>, transfercapability=16, exten=<value optimized out>,    requestor=<value optimized out>) at sig_pri.c:877 #1  0x00007f7f5a2c95dc in pri_dchannel (vpri=<value optimized out>) at sig_pri.c:4951 #2  0x000000000053707c in dummy_start (data=<value optimized out>) at utils.c:971 #3  0x00007f7f652c3fc7 in start_thread () from /lib/libpthread.so.0 #4  0x00007f7f65b0864d in clone () from /lib/libc.so.6 ASTERISK-1  0x0000000000000000 in ?? ()
Comments:	By: Digium Subversion (svnbot) 2011-02-23 17:38:05.000-0600 Repository: asterisk Revision: 308622 U   branches/1.8/channels/sig_pri.c ------------------------------------------------------------------------ r308622 | rmudgett | 2011-02-23 17:38:05 -0600 (Wed, 23 Feb 2011) | 9 lines sig_pri_new_ast_channel() should return NULL when new_ast_channel() fails. (closes issue ASTERISK-17464) Reported by: cmaj Patches:      patch-sig_pri-crash-possible-null-channel-pointer.diff.txt uploaded by cmaj (license 830) JIRA SWP-3172 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=308622 By: Digium Subversion (svnbot) 2011-02-23 17:45:03.000-0600 Repository: asterisk Revision: 308623 _U  trunk/ U   trunk/channels/sig_pri.c ------------------------------------------------------------------------ r308623 | rmudgett | 2011-02-23 17:45:02 -0600 (Wed, 23 Feb 2011) | 16 lines Merged revisions 308622 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........  r308622 | rmudgett | 2011-02-23 17:38:04 -0600 (Wed, 23 Feb 2011) | 9 lines    sig_pri_new_ast_channel() should return NULL when new_ast_channel() fails.    (closes issue ASTERISK-17464)  Reported by: cmaj  Patches:        patch-sig_pri-crash-possible-null-channel-pointer.diff.txt uploaded by cmaj (license 830)    JIRA SWP-3172 ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=308623