Summary:	ASTERISK-17472: [patch] allow storing TCP peers in ast db & alllow rtupdate=no to use them
Reporter:	cmaj (cmaj)	Labels:
Date Opened:	2011-02-24 12:35:43.000-0600	Date Closed:	2011-05-19 14:28:22
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/TCP-TLS
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) patch-chan_sip-1.8.3-rc2-allow-tcp-peer-store-db-and-readonly-rt-backend.diff.txt
Description:	A nasty comment about not keeping track of TCP peers was deleted and simple workaround offered in attached patch. It is safe to store TCP peers in AST DB just like UDP peers. Additionally, this patch covers situations with read-only realtime storage, which is great with LDAP backends because they are very much read-friendly. But without writing to the backend (when rtupdate="no" in sip.conf) you lose track of where the peers are during a restart of Asterisk - not good. ****** ADDITIONAL INFORMATION ****** I consider this a bug, not a feature, because when rtupdate="no" then local AST DB should kick-in for quasi-realtime TCP & UDP peers (same as it does for sip.conf defined UDP peers.) Although, maybe adding "rtlocalcache" option would be better than extending "rtupdate" ?
Comments:	By: cmaj (cmaj) 2011-02-28 15:04:40.000-0600 I've noticed that buddy notification to hint watching peers (SIP NOTIFY) doesn't work with this patch, but at least calls to the peer (SIP INVITE) are fine. Testing with mostly Polycom 560s. By: Digium Subversion (svnbot) 2011-05-13 12:56:06 Repository: asterisk Revision: 318917 U   branches/1.8/channels/chan_sip.c ------------------------------------------------------------------------ r318917 | bbryant | 2011-05-13 12:56:06 -0500 (Fri, 13 May 2011) | 11 lines This patch allows TCP peers into the ast_db where they were previously restricted. (closes issue ASTERISK-17472) Reported by: cmaj Patches:      patch-chan_sip-1.8.3-rc2-allow-tcp-peer-store-db-and-readonly-rt-backend.diff.txt      uploaded by cmaj (license 830) Tested by: cmaj ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=318917 By: Digium Subversion (svnbot) 2011-05-13 12:58:55 Repository: asterisk Revision: 318918 _U  trunk/ U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r318918 | bbryant | 2011-05-13 12:58:55 -0500 (Fri, 13 May 2011) | 17 lines Merged revisions 318917 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........  r318917 | bbryant | 2011-05-13 13:56:04 -0400 (Fri, 13 May 2011) | 11 lines    This patch allows TCP peers into the ast_db where they were previously  restricted.    (closes issue ASTERISK-17472)  Reported by: cmaj  Patches:        patch-chan_sip-1.8.3-rc2-allow-tcp-peer-store-db-and-readonly-rt-backend.diff.txt        uploaded by cmaj (license 830)  Tested by: cmaj ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=318918