Summary:	ASTERISK-17480: [patch] app_voicemail creates "general" mailbox from users.conf
Reporter:	Paul Dugas (pdugas)	Labels:
Date Opened:	2011-02-25 11:30:08.000-0600	Date Closed:	2011-05-17 07:54:17
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_voicemail-ignore-general.patch ( 1) app_voicemail-ignore-general-style-guidelines.patch
Description:	I use users.conf to centralize my station configs and noticed today that app_voicemail is creating a "general" mailbox.  Looking through the current "trunk" code, I find that app_voicemail is not skipping the [general] section as other modules that scan users.conf seem to (I looked at chan_sip specifically).
Comments:	By: Paul Dugas (pdugas) 2011-02-25 11:34:10.000-0600 The attached app_voicemail-ignore-general.patch file contains the addition of a   if (strcasecmp(cat, "general")) { ... } block around the processing of user.conf sections.  I have not tested this as I'm not in a position to easily do so at this time.   I did not include the indentation of the enclosed block so as to clarify the change. By: Paul Dugas (pdugas) 2011-03-01 19:44:44.000-0600 I have been able to test this and it appears to do the trick for me.  I no longer have a "general" mailbox and I can still use "hasvoicemail" in the [general] section of users.conf. By: Paul Dugas (pdugas) 2011-03-10 22:20:10.000-0600 I believe the "needs licenses" state can be un-done. By: Digium Subversion (svnbot) 2011-05-17 07:53:51 Repository: asterisk Revision: 319367 U   branches/1.8/apps/app_voicemail.c ------------------------------------------------------------------------ r319367 | lmadsen | 2011-05-17 07:53:51 -0500 (Tue, 17 May 2011) | 10 lines Don't create [general] voicemail context when using users.conf Prior to this patch, app_voicemail would create a [general] context when parsing users.conf. (closes issue ASTERISK-17480) Reported by: pdugas Patches:      app_voicemail-ignore-general.patch uploaded by pdugas (license 1222)      app_voicemail-ignore-general-style-guidelines.patch uploaded by seanbright (license 71) Tested by: pdugas ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=319367 By: Digium Subversion (svnbot) 2011-05-17 07:54:14 Repository: asterisk Revision: 319368 _U  trunk/ U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r319368 | lmadsen | 2011-05-17 07:54:14 -0500 (Tue, 17 May 2011) | 18 lines Merged revisions 319367 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........  r319367 | lmadsen | 2011-05-17 07:53:50 -0500 (Tue, 17 May 2011) | 10 lines    Don't create [general] voicemail context when using users.conf    Prior to this patch, app_voicemail would create a [general] context when parsing users.conf.    (closes issue ASTERISK-17480)  Reported by: pdugas  Patches:        app_voicemail-ignore-general.patch uploaded by pdugas (license 1222)        app_voicemail-ignore-general-style-guidelines.patch uploaded by seanbright (license 71)  Tested by: pdugas ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=319368