[Home]

Summary:ASTERISK-17483: Asterisk-R2 outgoing calls without CallerID
Reporter:Thiago Maluf (malufrj)Labels:
Date Opened:2011-02-27 11:34:42.000-0600Date Closed:2011-03-05 11:53:33.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:1.8.2 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I am migrating my Asterisk to Asterisk 1.8.2 after long time in Asterisk 1.6.
This update is due good echo cancel in Asterisk 1.8.

But when I did it my production system, I was alerted that outgoing calls are without caller id. My system works with ASterisk 1.8.2 and openr2 1.3.0.

Update my openr2 to 1.3.1 and it don't change the error.
Then I saw chan_dahdi.c and I found this point:

In sig_pri.c (to ISDN calls - don't have this error) the caller id is the ast->connected.id.number.str and chan_dahdi.c (to R2 calls - have this error) the caller id is the ast->caller.id.number.str .

And logging this variables, ast->caller.id.nuber.str is always EMPTY and ast->connected.id.number.str have the corrected value of ${CALLERID(num)}.

Then I change this source and fix my system.
Of course that I would know what is motive for it.



****** ADDITIONAL INFORMATION ******

It is the diff between original chan_dahdi.c and my chan_dahdi.c

5292c5292,5293
<                       l = ast->caller.id.number.valid ? ast->caller.id.number.str : NULL;
---
>                       /* l = ast->caller.id.number.valid ? ast->caller.id.number.str : NULL; // DONT WORK */
>                       l = ast->connected.id.number.valid ? ast->connected.id.number.str : NULL;
Comments:By: Moises Silva (moy) 2011-02-27 21:46:30.000-0600

Apparently something changed in the cid structure. I will update the code tomorrow morning as soon as I can test it to double check it works as expected.

Thanks for reporting it.
By: Digium Subversion (svnbot) 2011-03-05 11:44:32.000-0600

Repository: asterisk
Revision: 309720

U   branches/1.8/channels/chan_dahdi.c

------------------------------------------------------------------------
r309720 | moy | 2011-03-05 11:44:31 -0600 (Sat, 05 Mar 2011) | 6 lines

Fix caller id passed to openr2_chan_make_call

(closes issue ASTERISK-17483)
Reported by: malufrj
Tested by: moy

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=309720
By: Digium Subversion (svnbot) 2011-03-05 11:53:32.000-0600

Repository: asterisk
Revision: 309721

_U  trunk/
U   trunk/channels/chan_dahdi.c

------------------------------------------------------------------------
r309721 | moy | 2011-03-05 11:53:32 -0600 (Sat, 05 Mar 2011) | 13 lines

Merged revisions 309720 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r309720 | moy | 2011-03-05 12:44:30 -0500 (Sat, 05 Mar 2011) | 6 lines
 
 Fix caller id passed to openr2_chan_make_call
 
 (closes issue ASTERISK-17483)
 Reported by: malufrj
 Tested by: moy
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=309721