Summary:	ASTERISK-17540: SDP origin attribute modified when issuing re-INVITE because of directmedia=yes
Reporter:	saghul (saghul)	Labels:
Date Opened:	2011-03-10 17:18:21.000-0600	Date Closed:	2017-09-07 13:06:44
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Interoperability
Versions:		Frequency of Occurrence
Related Issues:	is related to ASTERISK-15001 chan_sip breaks RFC by incrementing session version between non-reliable 1xx and 200
Environment:		Attachments:	( 0) asterisk_r310240_sip_reinvite_modified_origin.txt
Description:	When directmedia=yes is set Asterisk will generate a re-INVITE with a new SDP offer to both parties. This offer must not modify the SDP origin attribute (o=) but for the version number. Extract from RFC3264, sec 8: "When issuing an offer that modifies the session,  the "o=" line of the new SDP MUST be identical to that in the  previous SDP, except that the version in the origin field MUST  increment by one from the previous SDP." The attached SIP trace from the CLI shows the described behavior.
Comments:	By: David Woolley (davidw) 2013-02-21 08:58:51.929-0600 This appears to be a correct, and necessary, update to the version. It is happening after the ACK, so it is a correctly placed re-invite. By: saghul (saghul) 2013-02-21 09:04:43.897-0600 Look carefully, the IP address is also changed, which is not right according to the RFC extract I referenced. By: Friendly Automation (friendly-automation) 2017-09-07 13:06:45.855-0500 Change 6422 merged by Jenkins2: chan_sip: Do not change IP address in SDP origin line (o=) in SIP reINVITE [https://gerrit.asterisk.org/6422|https://gerrit.asterisk.org/6422] By: Friendly Automation (friendly-automation) 2017-09-07 13:07:49.542-0500 Change 6419 merged by Jenkins2: chan_sip: Do not change IP address in SDP origin line (o=) in SIP reINVITE [https://gerrit.asterisk.org/6419|https://gerrit.asterisk.org/6419] By: Friendly Automation (friendly-automation) 2017-09-07 13:19:49.399-0500 Change 6420 merged by Jenkins2: chan_sip: Do not change IP address in SDP origin line (o=) in SIP reINVITE [https://gerrit.asterisk.org/6420|https://gerrit.asterisk.org/6420] By: Friendly Automation (friendly-automation) 2017-09-07 13:38:28.484-0500 Change 6421 merged by Joshua Colp: chan_sip: Do not change IP address in SDP origin line (o=) in SIP reINVITE [https://gerrit.asterisk.org/6421|https://gerrit.asterisk.org/6421]