Summary:	ASTERISK-17548: [patch] CEL cel_odbc backend fails to insert eventtype into integer or other numeric column
Reporter:	Kirill Katsnelson (kkm)	Labels:
Date Opened:	2011-03-13 10:49:32	Date Closed:	2012-03-07 15:36:19.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	CEL/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 018964-cel-odbc-eventtype-and-datetime2.1.8.diff ( 1) 018964-cel-odbc-eventtype-and-datetime2.diff ( 2) 018964-cel-odbc-eventtype-and-datetime2-1.10.312554.diff
Description:	If eventtype is numeric in the database, it gets set to NULL, not to the numeric value documented in cel_odbc.conf.sample. ****** ADDITIONAL INFORMATION ****** Patch also implements correct handling of datetime2 and datetimeoffset new datatypes in SQL Server 2008 and 2008 R2.
Comments:	By: Kirill Katsnelson (kkm) 2011-03-13 10:57:54 @lmadsen: there is no category CEL/cel_odbc like CDR/cdr_odbc in the issue report form. By: Tilghman Lesher (tilghman) 2011-03-14 16:33:42 You need to wrap uses of ODBC wide character types with #ifdef HAVE_ODBC_WCHAR, as is done in res/res_config_odbc.c.  I'd also like to see this patch promoted to reviewboard. By: Kirill Katsnelson (kkm) 2011-03-14 17:40:28 Will do. By: Kirill Katsnelson (kkm) 2011-04-03 21:53:11 Updated patch per tilghman suggestion. Posted reviewboard entry https://reviewboard.asterisk.org/r/1160/ By: Matt Jordan (mjordan) 2011-11-21 13:59:18.976-0600 This patch received a ship it sometime ago - do you need a committer to shepherd the patch into the codebase? By: Kirill Katsnelson (kkm) 2011-11-21 14:26:36.887-0600 Matt, yes, please, and thank you very much. I do not know how to get attention to my patches. Many of these just sit there for years like entries into an oldest patch contest. There are a few other ones that have been sitting there for ages:\\ ASTERISK-16508\\ ASTERISK-17639\\ ASTERISK-16508\\ ASTERISK-16467 I would appreciate if you or somebody else could have a look at these too. By: Terry Wilson (twilson) 2012-01-03 14:11:29.251-0600 Assigning to Tilghman as he has a change he wants to make/test before committing.