Summary:	ASTERISK-17569: [patch] Can't return to normal ring after distinctive ring on FXS
Reporter:	Marc Purdon (bromont)	Labels:
Date Opened:	2011-03-16 22:20:37	Date Closed:	2011-04-22 18:01:41
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_dahdi
Versions:	1.8.3	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) bug18985.diff.txt
Description:	When dialing an FXS line using DAHDI/1r3 (3 short rings), subsequent FXS calls always produce the 3 short rings even though DAHDI/1 should produce the default ring. Only after an Asterisk restart can the normal ring be restored. ****** ADDITIONAL INFORMATION ****** I use both DAHDI/1 and DAHDI/1r3 to distinguish calls destined for certain people. This worked great until the upgrade to Asterisk 1.8/Dahdi 2.4.x. Now the normal ring is heard until DAHDI/1r3 is called then all FXS calls ring as DAHDI/1r3 (even though DAHDI/1 is called) until Asterisk is restarted.
Comments:	By: Alec Davis (alecdavis) 2011-03-21 03:49:25 bug18985.diff.txt in dahdi_request set p->distinctivering=0 before checking whether r1 etc is present By: Alec Davis (alecdavis) 2011-03-21 12:45:08 Although this works, in hindsite, it's probably not the best place to reset the distinctive ring. A better place is in the offhook and hangup, that would leave the dring set to default while idle, also covers the ringback when you've placed a call on hold but then just hungup. By: Marc Purdon (bromont) 2011-03-21 14:22:23 I added p->dintinctivering=0 to line 13282 (rev 301134) and compiled, I will test and report results tonight. I took a look at dahdi_hangup and I'm not sure where to reset in that function. By: Marc Purdon (bromont) 2011-03-21 18:13:27 OK, I've tested the patch and all is working good. However if this isn't the best place to reset the distinctive ring I'd be eager to test that as well. By: Marc Purdon (bromont) 2011-03-21 21:31:16 Just wanted to add that calls aren't always answered on the DAHDI line. The dial string used is similar to Dial(SIP/phone1&SIP/phone2&Dahdi/1) or alternatively Dial(SIP/phone1&SIP/phone2&Dahdi/1r3), not sure if it has a bearing on placing the reset in the offhook and hangup section. In any case all is working with the current patch. By: Digium Subversion (svnbot) 2011-04-22 17:59:19 Repository: asterisk Revision: 315001 U   branches/1.8/channels/chan_dahdi.c ------------------------------------------------------------------------ r315001 | alecdavis | 2011-04-22 17:59:19 -0500 (Fri, 22 Apr 2011) | 12 lines chan_dahdi: Can't return to normal ring after distinctive ring on FXS clear a previous distinctivering pattern before each new call (closes issue ASTERISK-17569) Reported by: bromont Patches:      bug18985.diff.txt uploaded by alecdavis (license 585) Tested by: alecdavis, bromont ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=315001 By: Digium Subversion (svnbot) 2011-04-22 18:01:40 Repository: asterisk Revision: 315002 _U  trunk/ U   trunk/channels/chan_dahdi.c ------------------------------------------------------------------------ r315002 | alecdavis | 2011-04-22 18:01:39 -0500 (Fri, 22 Apr 2011) | 17 lines Merged revisions 315001 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........  r315001 | alecdavis | 2011-04-23 10:59:18 +1200 (Sat, 23 Apr 2011) | 12 lines    chan_dahdi: Can't return to normal ring after distinctive ring on FXS    clear a previous distinctivering pattern before each new call    (closes issue ASTERISK-17569)  Reported by: bromont  Patches:        bug18985.diff.txt uploaded by alecdavis (license 585)  Tested by: alecdavis, bromont ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=315002