Summary:	ASTERISK-17599: [patch] IAX can select the wrong channel name
Reporter:	Steve Davies (one47)	Labels:	patch
Date Opened:	2011-03-24 05:20:56	Date Closed:
Priority:	Minor	Regression?	No
Status:	Open/New	Components:	Channels/chan_iax2
Versions:	1.6.2.17 13.18.4	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) iax_username.1.6.2.17-rc1.patch
Description:	If more than one IAX user connects from the same IP address, then the wrong IAX2/"name" channel name can be allocated. The code path to determine which IAX user is used for authentication is different from the code path that determines which name is put into the channel-name field. The following IAX config (slightly edited) causes an issue for me in version 1.6.2. {code} [user1] type=friend auth=md5 accountcode=user1 notransfer=yes context=context1 host=10.0.0.250 username=user1 secret=secret1 disallow=all allow=alaw [user2] type=friend auth=md5 accountcode=user2 notransfer=yes context=context2 host=dynamic deny=0.0.0.0/0.0.0.0 permit=10.0.0.0/24 username=user2 secret= disallow=all allow=alaw {code} If a call comes in from 10.0.0.250, using username "user2" and with no password, then it is correctly authenticated against the {{\[user2\]}} section.   Accountcode is set to user2   Context is set to context2 and the call mostly proceeds correctly, BUT the source channel name is set to IAX2/user1-nnnn, which is then seen both in the dialplan debug output, and in the CDR. This is because the channel name is found by using the first matching IP address in the configuration, rather than using the section that was used for authentication.
Comments:	By: Steve Davies (one47) 2011-03-24 05:22:00 I believe that the fix is to allocate the channel name earlier, at the same time that the authentication target is selected. I will upload a proposed patch to do this for comment.