| Summary: | ASTERISK-17633: [patch] Chan_local crashes in fixup | ||
| Reporter: | Olle Johansson (oej) | Labels: | |
| Date Opened: | 2011-04-01 09:02:24 | Date Closed: | 2011-05-03 16:45:48 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_local |
| Versions: | 1.6.2.17 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | The "don't bridge to myself" patch assumes that both p->owner and p->chan exists, which may not be the case. During testing, our Asterisk crashed when p->chan was NULL and p->chan->bridge of course did not exist in this universe. | ||
| Comments: | By: Olle Johansson (oej) 2011-04-01 09:06:01 Patch on reviewboard. By: Olle Johansson (oej) 2011-04-06 04:06:05 I would consider this a blocker for ANY new release. By: Digium Subversion (svnbot) 2011-05-03 16:28:00 Repository: asterisk Revision: 316328 U branches/1.4/channels/chan_local.c ------------------------------------------------------------------------ r316328 | dvossel | 2011-05-03 16:27:59 -0500 (Tue, 03 May 2011) | 10 lines Fixes chan_local crashs in local_fixup() Thanks OEJ for tracking down the issue and submitting the patch. (closes issue ASTERISK-17633) Reported by: oej Tested by: oej Review: https://reviewboard.asterisk.org/r/1158/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=316328 By: Digium Subversion (svnbot) 2011-05-03 16:29:56 Repository: asterisk Revision: 316329 _U branches/1.6.2/ U branches/1.6.2/channels/chan_local.c ------------------------------------------------------------------------ r316329 | dvossel | 2011-05-03 16:29:56 -0500 (Tue, 03 May 2011) | 17 lines Merged revisions 316328 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r316328 | dvossel | 2011-05-03 16:27:59 -0500 (Tue, 03 May 2011) | 10 lines Fixes chan_local crashs in local_fixup() Thanks OEJ for tracking down the issue and submitting the patch. (closes issue ASTERISK-17633) Reported by: oej Tested by: oej Review: https://reviewboard.asterisk.org/r/1158/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=316329 By: Digium Subversion (svnbot) 2011-05-03 16:37:59 Repository: asterisk Revision: 316330 _U branches/1.8/ U branches/1.8/channels/chan_local.c ------------------------------------------------------------------------ r316330 | dvossel | 2011-05-03 16:37:59 -0500 (Tue, 03 May 2011) | 24 lines Merged revisions 316329 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ................ r316329 | dvossel | 2011-05-03 16:29:55 -0500 (Tue, 03 May 2011) | 17 lines Merged revisions 316328 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r316328 | dvossel | 2011-05-03 16:27:59 -0500 (Tue, 03 May 2011) | 10 lines Fixes chan_local crashs in local_fixup() Thanks OEJ for tracking down the issue and submitting the patch. (closes issue ASTERISK-17633) Reported by: oej Tested by: oej Review: https://reviewboard.asterisk.org/r/1158/ ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=316330 By: Digium Subversion (svnbot) 2011-05-03 16:45:47 Repository: asterisk Revision: 316332 _U trunk/ U trunk/channels/chan_local.c ------------------------------------------------------------------------ r316332 | dvossel | 2011-05-03 16:45:46 -0500 (Tue, 03 May 2011) | 31 lines Merged revisions 316330 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................ r316330 | dvossel | 2011-05-03 16:37:59 -0500 (Tue, 03 May 2011) | 24 lines Merged revisions 316329 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ................ r316329 | dvossel | 2011-05-03 16:29:55 -0500 (Tue, 03 May 2011) | 17 lines Merged revisions 316328 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r316328 | dvossel | 2011-05-03 16:27:59 -0500 (Tue, 03 May 2011) | 10 lines Fixes chan_local crashs in local_fixup() Thanks OEJ for tracking down the issue and submitting the patch. (closes issue ASTERISK-17633) Reported by: oej Tested by: oej Review: https://reviewboard.asterisk.org/r/1158/ ........ ................ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=316332 | ||