| Summary: | ASTERISK-17670: [patch] tcptls.c fails building with no SSL2 support | ||
| Reporter: | Tzafrir Cohen (tzafrir) | Labels: | |
| Date Opened: | 2011-04-11 05:44:42 | Date Closed: | 2011-04-19 10:42:33 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/Netsock |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) no_ssl2.diff | |
| Description: | SSL2 is an old and insecure variant of the SSL/TLS protocol. OpenSSL provides a build-time option for building with no support of it (this is e.g. needed to comply with various standards). Asterisk fails to build in such cases. Patch attached. | ||
| Comments: | By: Russell Bryant (russell) 2011-04-11 14:15:48 patch looks fine to me By: Leif Madsen (lmadsen) 2011-04-11 14:48:08 I can't apply this to 1.6.2 -- should it apply there? If so, can you provide a 1.6.2 patch? Thanks! By: Charles Moye (chazzam) 2011-04-19 09:42:09 It looks like 1.6.2 just always uses the SSLv23* method instead of a call to each specific one. So it shouldn't be needed for 1.6.2. By: Digium Subversion (svnbot) 2011-04-19 10:42:11 Repository: asterisk Revision: 314251 U branches/1.8/main/tcptls.c ------------------------------------------------------------------------ r314251 | lmadsen | 2011-04-19 10:42:11 -0500 (Tue, 19 Apr 2011) | 8 lines Use SSLv23_client_method instead of old SSLv2 only. (closes issue ASTERISK-17670) (closes issue ASTERISK-17710) Reported by: tzafrir Patches: no_ssl2.diff uploaded by tzafrir (license 46) Tested by: russell, chazzam ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=314251 By: Digium Subversion (svnbot) 2011-04-19 10:42:33 Repository: asterisk Revision: 314252 _U trunk/ U trunk/main/tcptls.c ------------------------------------------------------------------------ r314252 | lmadsen | 2011-04-19 10:42:32 -0500 (Tue, 19 Apr 2011) | 16 lines Merged revisions 314251 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........ r314251 | lmadsen | 2011-04-19 10:42:10 -0500 (Tue, 19 Apr 2011) | 8 lines Use SSLv23_client_method instead of old SSLv2 only. (closes issue ASTERISK-17670) (closes issue ASTERISK-17710) Reported by: tzafrir Patches: no_ssl2.diff uploaded by tzafrir (license 46) Tested by: russell, chazzam ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=314252 | ||