[Home]

Summary:ASTERISK-17707: [patch] Unclear code in app_dial.c
Reporter:Olle Johansson (oej)Labels:
Date Opened:2011-04-18 09:03:26Date Closed:2011-04-18 11:25:08
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_dial
Versions:1.8.3 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) dialconfused.txt
Description:The code that handles AST_CONTROL_PROGRESS in the function wait_for_answer has unclear formatting. The line checking for OPT_RINGBACK has no curly brackets, so it only applies to the next level if. There's a second if() statement where indents indicate that it should be part of the RINGBACK clause, but it is not. I can't say what's righ there, so someone else needs to check the code and decide. Thanks.

****** ADDITIONAL INFORMATION ******

Code is attached
Comments:By: Digium Subversion (svnbot) 2011-04-18 11:02:13

Repository: asterisk
Revision: 314068

U   branches/1.8/apps/app_dial.c

------------------------------------------------------------------------
r314068 | rmudgett | 2011-04-18 11:02:12 -0500 (Mon, 18 Apr 2011) | 7 lines

Unclear code in app_dial.c.

Make code formatting clear.

(closes issue ASTERISK-17707)
Reported by: oej

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=314068
By: Digium Subversion (svnbot) 2011-04-18 11:25:07

Repository: asterisk
Revision: 314079

_U  trunk/
U   trunk/apps/app_dial.c

------------------------------------------------------------------------
r314079 | rmudgett | 2011-04-18 11:25:07 -0500 (Mon, 18 Apr 2011) | 14 lines

Merged revisions 314068 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r314068 | rmudgett | 2011-04-18 11:02:12 -0500 (Mon, 18 Apr 2011) | 7 lines
 
 Unclear code in app_dial.c.
 
 Make code formatting clear.
 
 (closes issue ASTERISK-17707)
 Reported by: oej
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=314079