Summary:	ASTERISK-17714: [patch] app_voicemail.c does not compile in 1.4 branch
Reporter:	Kristijan Vrban (vrban)	Labels:
Date Opened:	2011-04-19 07:32:25	Date Closed:	2011-04-19 13:37:10
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:	1.8.4	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_voicemail_fix_for_312070.patch
Description:	attached the patch ****** ADDITIONAL INFORMATION ******  [CC] app_voicemail.c -> app_voicemail.o app_voicemail.c: In function ‘last_message_index’: app_voicemail.c:2574: error: ‘AST_LOG_DEBUG’ undeclared (first use in this function) app_voicemail.c:2574: error: (Each undeclared identifier is reported only once app_voicemail.c:2574: error: for each function it appears in.) app_voicemail.c:2574: warning: passing argument 3 of ‘ast_log’ makes integer from pointer without a cast /home/kristijan.vrban/1.4/include/asterisk/logger.h:62: note: expected ‘int’ but argument is of type ‘char *’ app_voicemail.c:2574: error: too few arguments to function ‘ast_log’ app_voicemail.c:2576: error: ‘AST_LOG_WARNING’ undeclared (first use in this function) app_voicemail.c:2576: warning: passing argument 3 of ‘ast_log’ makes integer from pointer without a cast /home/kristijan.vrban/1.4/include/asterisk/logger.h:62: note: expected ‘int’ but argument is of type ‘char *’ app_voicemail.c:2576: error: too few arguments to function ‘ast_log’ app_voicemail.c: In function ‘count_messages’: app_voicemail.c:2663: error: ‘AST_LOG_WARNING’ undeclared (first use in this function) app_voicemail.c:2663: warning: passing argument 3 of ‘ast_log’ makes integer from pointer without a cast /home/kristijan.vrban/1.4/include/asterisk/logger.h:62: note: expected ‘int’ but argument is of type ‘char *’ app_voicemail.c:2663: error: too few arguments to function ‘ast_log’ app_voicemail.c:2669: warning: passing argument 3 of ‘ast_log’ makes integer from pointer without a cast /home/kristijan.vrban/1.4/include/asterisk/logger.h:62: note: expected ‘int’ but argument is of type ‘char *’ app_voicemail.c:2669: error: too few arguments to function ‘ast_log’ app_voicemail.c:2676: warning: passing argument 3 of ‘ast_log’ makes integer from pointer without a cast /home/kristijan.vrban/1.4/include/asterisk/logger.h:62: note: expected ‘int’ but argument is of type ‘char *’ app_voicemail.c:2676: error: too few arguments to function ‘ast_log’ app_voicemail.c:2682: error: too few arguments to function ‘ast_log’ app_voicemail.c:2687: warning: passing argument 3 of ‘ast_log’ makes integer from pointer without a cast /home/kristijan.vrban/1.4/include/asterisk/logger.h:62: note: expected ‘int’ but argument is of type ‘char *’ app_voicemail.c:2687: error: too few arguments to function ‘ast_log’ app_voicemail.c: In function ‘open_mailbox’: app_voicemail.c:6086: error: ‘res’ undeclared (first use in this function) make[1]: *** [app_voicemail.o] Error 1 make: *** [apps] Error 2
Comments:	By: Leif Madsen (lmadsen) 2011-04-19 07:34:01 The changing of the ast_log() stuff was necessary to make things compile? By: Kristijan Vrban (vrban) 2011-04-19 07:38:12 >The changing of the ast_log() stuff was necessary to make things compile? yes. AST_LOG_* is not defined in 1.4 it is only LOG_* in 1.4 By: Leif Madsen (lmadsen) 2011-04-19 08:46:25 Huh odd, wonder what commit caused that regression? By: Paul Belanger (pabelanger) 2011-04-19 08:48:47 Or why bamboo didn't catch it.  Checking the logs now. By: Kristijan Vrban (vrban) 2011-04-19 09:01:08 >Huh odd, wonder what commit caused that regression? 312070 >Or why bamboo didn't catch it. Checking the logs now. Because ODBC_STORAGE must be enabled therewith the issue happened By: Leif Madsen (lmadsen) 2011-04-19 09:03:49 OK well now we know the why :) seanbright mentioned the last part of the patch looks unrelated. By: Alec Davis (alecdavis) 2011-04-19 13:27:41 I'm on to it. will commit patch shortly. By: Digium Subversion (svnbot) 2011-04-19 13:37:09 Repository: asterisk Revision: 314300 U   branches/1.4/apps/app_voicemail.c ------------------------------------------------------------------------ r314300 | alecdavis | 2011-04-19 13:37:08 -0500 (Tue, 19 Apr 2011) | 11 lines app_voicemail: Fix ODBC Storage compile regression caused by me, from mantis bug ASTERISK-17613 / commit r312070 (closes issue ASTERISK-17714) Reported by: vrban Patches:      app_voicemail_fix_for_312070.patch uploaded by vrban (license 756) Tested by: vrban, alecdavis ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=314300