[Home]

Summary:ASTERISK-17747: [patch] check_bridge(): misplaced ast_mutex_unlock
Reporter:Alec Davis (alecdavis)Labels:
Date Opened:2011-04-25 02:00:12Date Closed:2011-04-25 03:01:45
Priority:MinorRegression?Yes
Status:Closed/CompleteComponents:Channels/chan_local
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) bug19176.diff.txt
Description:<pre>
if (!ast_mutex_trylock(&(p->chan->_bridge)->lock)) {
 if (!p->chan->_bridge->_softhangup) {
   ....
   ast_mutex_unlock(&(p->chan->_bridge)->lock); <b><u> <<< WHAT </u></b>
 }
}</pre>



****** ADDITIONAL INFORMATION ******

<pre>
if (!ast_mutex_trylock(&(p->chan->_bridge)->lock)) {
 if (!p->chan->_bridge->_softhangup) {
   ....
 }
 ast_mutex_unlock(&(p->chan->_bridge)->lock);
}</pre>
Comments:By: Digium Subversion (svnbot) 2011-04-25 02:06:32

Repository: asterisk
Revision: 315051

U   branches/1.4/channels/chan_local.c

------------------------------------------------------------------------
r315051 | alecdavis | 2011-04-25 02:06:30 -0500 (Mon, 25 Apr 2011) | 11 lines

chan_local:check_bridge() misplaced misplaced ast_mutex_unlock

if !p->chan->_bridge->_softhangup path isn't followed, brigde remains locked.

(closes issue ASTERISK-17747)
Reported by: alecdavis
Patches:
     bug19176.diff.txt uploaded by alecdavis (license 585)



------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=315051
By: Digium Subversion (svnbot) 2011-04-25 02:11:13

Repository: asterisk
Revision: 315052

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_local.c

------------------------------------------------------------------------
r315052 | alecdavis | 2011-04-25 02:11:13 -0500 (Mon, 25 Apr 2011) | 16 lines

Merged revisions 315051 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r315051 | alecdavis | 2011-04-25 19:06:29 +1200 (Mon, 25 Apr 2011) | 11 lines
 
 chan_local:check_bridge() misplaced misplaced ast_mutex_unlock
 
 if !p->chan->_bridge->_softhangup path isn't followed, brigde remains locked.
 
 (closes issue ASTERISK-17747)
 Reported by: alecdavis
 Patches:
       bug19176.diff.txt uploaded by alecdavis (license 585)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=315052
By: Digium Subversion (svnbot) 2011-04-25 02:14:33

Repository: asterisk
Revision: 315053

_U  branches/1.8/
U   branches/1.8/channels/chan_local.c

------------------------------------------------------------------------
r315053 | alecdavis | 2011-04-25 02:14:32 -0500 (Mon, 25 Apr 2011) | 23 lines

Merged revisions 315052 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r315052 | alecdavis | 2011-04-25 19:11:12 +1200 (Mon, 25 Apr 2011) | 16 lines
 
 Merged revisions 315051 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r315051 | alecdavis | 2011-04-25 19:06:29 +1200 (Mon, 25 Apr 2011) | 11 lines
   
   chan_local:check_bridge() misplaced misplaced ast_mutex_unlock
   
   if !p->chan->_bridge->_softhangup path isn't followed, brigde remains locked.
   
   (closes issue ASTERISK-17747)
   Reported by: alecdavis
   Patches:
         bug19176.diff.txt uploaded by alecdavis (license 585)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=315053
By: Digium Subversion (svnbot) 2011-04-25 02:17:28

Repository: asterisk
Revision: 315054

_U  trunk/
U   trunk/channels/chan_local.c

------------------------------------------------------------------------
r315054 | alecdavis | 2011-04-25 02:17:28 -0500 (Mon, 25 Apr 2011) | 30 lines

Merged revisions 315053 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r315053 | alecdavis | 2011-04-25 19:14:32 +1200 (Mon, 25 Apr 2011) | 23 lines
 
 Merged revisions 315052 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r315052 | alecdavis | 2011-04-25 19:11:12 +1200 (Mon, 25 Apr 2011) | 16 lines
   
   Merged revisions 315051 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r315051 | alecdavis | 2011-04-25 19:06:29 +1200 (Mon, 25 Apr 2011) | 11 lines
     
     chan_local:check_bridge() misplaced misplaced ast_mutex_unlock
     
     if !p->chan->_bridge->_softhangup path isn't followed, brigde remains locked.
     
     (closes issue ASTERISK-17747)
     Reported by: alecdavis
     Patches:
           bug19176.diff.txt uploaded by alecdavis (license 585)
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=315054
By: Alec Davis (alecdavis) 2011-04-25 03:01:45

regression since r6830
http://svnview.digium.com/svn/asterisk?view=revision&revision=6830