[Home]

Summary:ASTERISK-17757: [patch] dahdi_hangup() doesnt clean up / hang up the channel correctly/fully
Reporter:jg1234 (jg1234)Labels:
Date Opened:2011-04-27 07:27:37Date Closed:2011-05-03 14:22:32
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:1.8.3 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue19188_v1.8.patch
Description:after dahdi_hangup() has supposedly hungup a isdn/pri channel there is still traffic on the S0-bus because the channel wasnt cleaned up fully


****** ADDITIONAL INFORMATION ******

this is not the case in version asterisk-1.6.2.17.2
Comments:By: jg1234 (jg1234) 2011-04-27 07:39:59

here is a way arround that ... i guess this is unlicensed then <link to unlicensed code remove by lmadsen />
and i am not going to sign up for those 2 lines

or to say in other words
check the "goto" ...


By: Leif Madsen (lmadsen) 2011-04-27 11:02:13

I have removed your link to unlicensed code. Please sign the license agreement if you wish for people to review your code.
By: Richard Mudgett (rmudgett) 2011-04-27 12:52:40

The issue19188_v1.8.patch file shuffles the hangup code to include some missing cleanup.  The patch also fixes some code formatting in the area.
By: jg1234 (jg1234) 2011-04-28 00:58:52

Thank you rmudgett that fixed it.
By: Digium Subversion (svnbot) 2011-05-03 14:18:33

Repository: asterisk
Revision: 316224

U   branches/1.8/channels/chan_dahdi.c
U   branches/1.8/channels/sig_analog.c
U   branches/1.8/channels/sig_pri.c

------------------------------------------------------------------------
r316224 | rmudgett | 2011-05-03 14:18:32 -0500 (Tue, 03 May 2011) | 16 lines

The dahdi_hangup() call does not clean up the channel fully.

After dahdi_hangup() has supposedly hungup an ISDN channel there is still
traffic on the S0-bus because the channel was not cleaned up fully.

Shuffled the hangup code to include some missing cleanup.  Also fixed some
code formatting in the area.  I think the primary missing clean up code
was the call to tone_zone_play_tone() to turn off any active tones on the
channel.

(closes issue ASTERISK-17757)
Reported by: jg1234
Patches:
     issue19188_v1.8.patch uploaded by rmudgett (license 664)
Tested by: jg1234

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=316224
By: Digium Subversion (svnbot) 2011-05-03 14:22:31

Repository: asterisk
Revision: 316240

_U  trunk/
U   trunk/channels/chan_dahdi.c
U   trunk/channels/sig_analog.c
U   trunk/channels/sig_pri.c

------------------------------------------------------------------------
r316240 | rmudgett | 2011-05-03 14:22:31 -0500 (Tue, 03 May 2011) | 23 lines

Merged revisions 316224 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r316224 | rmudgett | 2011-05-03 14:18:30 -0500 (Tue, 03 May 2011) | 16 lines
 
 The dahdi_hangup() call does not clean up the channel fully.
 
 After dahdi_hangup() has supposedly hungup an ISDN channel there is still
 traffic on the S0-bus because the channel was not cleaned up fully.
 
 Shuffled the hangup code to include some missing cleanup.  Also fixed some
 code formatting in the area.  I think the primary missing clean up code
 was the call to tone_zone_play_tone() to turn off any active tones on the
 channel.
 
 (closes issue ASTERISK-17757)
 Reported by: jg1234
 Patches:
       issue19188_v1.8.patch uploaded by rmudgett (license 664)
 Tested by: jg1234
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=316240