[Home]

Summary:ASTERISK-17764: [patch] When SIP caller does not offer video, adding video drops the call
Reporter:Steve Davies (one47)Labels:
Date Opened:2011-04-28 06:34:51Date Closed:2011-05-09 19:22:05
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/CodecHandling
Versions:1.6.2.18 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sip_cant_add_video_rtp
Description:2 video capable SIP devices on the same LAN (directmedia enabled)

Caller sends an initial INVITE, but does NOT include any video, then no video-rtp object is initialised. Video is still offered to the callee, as they are capable of it.

If the callee then requests video, then the attempt to enable direct media causes the call to be dropped as the SDP data gets very confused by having video requested, but no video-rtp object at the same time.

****** ADDITIONAL INFORMATION ******

This was introduced by a patch which I provided that was merged in 1.6.2.17 or 1.6.2.18 issueASTERISK-16153.

The patch is an improvement to codec negotiation, but misses the above case.

It can be fixed by the patch attached, but there may be a better way to do it - It feels "ugly" to me. It checks that p->jointcapability includes at least one shared video codec before allowing video codecs to be part of a directmedia re-INVITE.

Tested with X-Lite / Eyebeam as follows:

Caller - Request audio-call only.
Callee - Answer as audio call.
Callee - Request video enabled.

Without patch, call is dropped, with patch, video is rejected as chan_sip does not currently appear to have a way to add video rtp retrospectively.
Comments:By: Terry Wilson (twilson) 2011-05-09 14:49:43

Looks good to me. I misread the patch and made a silly recommendation which I have since deleted. :-)
By: Digium Subversion (svnbot) 2011-05-09 15:04:42

Repository: asterisk
Revision: 318331

U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r318331 | twilson | 2011-05-09 15:04:42 -0500 (Mon, 09 May 2011) | 12 lines

Don't offer video to directmedia callee unless caller offered it as well

Make sure that when directmedia is enabled, that video is not offered to the
callee even if it supports it. p->vrtp will not exist since the caller didn't
offer video.

(closes issue ASTERISK-17764)
Reported by: one47
Patches:
     sip_cant_add_video_rtp uploaded by one47 (license 23)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=318331
By: Digium Subversion (svnbot) 2011-05-09 15:23:17

Repository: asterisk
Revision: 318337

_U  branches/1.8/
U   branches/1.8/channels/chan_sip.c

------------------------------------------------------------------------
r318337 | twilson | 2011-05-09 15:23:17 -0500 (Mon, 09 May 2011) | 18 lines

Merged revisions 318331 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r318331 | twilson | 2011-05-09 15:04:41 -0500 (Mon, 09 May 2011) | 12 lines
 
 Don't offer video to directmedia callee unless caller offered it as well
 
 Make sure that when directmedia is enabled, that video is not offered to the
 callee even if it supports it. p->vrtp will not exist since the caller didn't
 offer video.
 
 (closes issue ASTERISK-17764)
 Reported by: one47
 Patches:
       sip_cant_add_video_rtp uploaded by one47 (license 23)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=318337
By: Digium Subversion (svnbot) 2011-05-09 19:22:04

Repository: asterisk
Revision: 318400

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r318400 | twilson | 2011-05-09 19:22:04 -0500 (Mon, 09 May 2011) | 25 lines

Merged revisions 318337 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r318337 | twilson | 2011-05-09 15:23:15 -0500 (Mon, 09 May 2011) | 18 lines
 
 Merged revisions 318331 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r318331 | twilson | 2011-05-09 15:04:41 -0500 (Mon, 09 May 2011) | 12 lines
   
   Don't offer video to directmedia callee unless caller offered it as well
   
   Make sure that when directmedia is enabled, that video is not offered to the
   callee even if it supports it. p->vrtp will not exist since the caller didn't
   offer video.
   
   (closes issue ASTERISK-17764)
   Reported by: one47
   Patches:
         sip_cant_add_video_rtp uploaded by one47 (license 23)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=318400