[Home]

Summary:ASTERISK-17782: [patch] bug in contrib/scripts/safe_asterisk
Reporter:Sergey Sidlyarenko (lefoyer)Labels:
Date Opened:2011-05-03 04:05:33Date Closed:2011-05-05 10:07:01
Priority:MinorRegression?No
Status:Closed/CompleteComponents:General
Versions:1.6.2.18 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue19213_strip_color_in_safe_asterisk-svn.patch
Description:safe_asterisk script not check running Asterisk because he returns unprintable characters. test Centos 5.5 and Debian squeeze.

test on Centos 5.5
/usr/sbin/asterisk -rx 'core show version'|cat -t
^[[0;37mAsterisk 1.6.2.13 built by root @ rpmbuild32-2.elastix.palosanto.com on a i686 running Linux on 2010-10-03 20:56:35 UTC
^[[0m

test on Debian squeeze
/usr/sbin/asterisk -rx 'core show version'|cat -t
^[[0;37mAsterisk 1.8.3-1digium1~squeeze built by pbuilder @ nighthawk on a x86_64 running Linux on 2011-03-17 15:31:24 UTC
^[[0m



****** ADDITIONAL INFORMATION ******

Removed inline patch - pabelanger
Comments:By: Walter Doekes (wdoekes) 2011-05-03 07:54:51

.. or you could do -nrx instead of -rx
By: Paul Belanger (pabelanger) 2011-05-03 09:53:44

Please upload your patch to the issue tracker
By: Sergey Sidlyarenko (lefoyer) 2011-05-04 02:12:09

-nrx work correctly

Sample:
root@ns:~# /usr/sbin/asterisk -nrx "core show version"|cat -t
Asterisk 1.8.3-1digium1~squeeze built by pbuilder @ nighthawk on a x86_64 running Linux on 2011-03-17 15:31:24 UTC
root@ns:~#
By: Walter Doekes (wdoekes) 2011-05-04 02:20:17

.. uploaded patch so we can get this out of the way.
By: Sergey Sidlyarenko (lefoyer) 2011-05-04 03:13:44

Please apply the patch to branches 1.6 and 1.8, the file safe_asterisk in these branches of identical.
By: Digium Subversion (svnbot) 2011-05-05 09:54:47

Repository: asterisk
Revision: 317102

U   branches/1.4/contrib/scripts/safe_asterisk

------------------------------------------------------------------------
r317102 | lmadsen | 2011-05-05 09:54:46 -0500 (Thu, 05 May 2011) | 8 lines

Disable console colourization inside safe_asterisk checks.

(closes issue ASTERISK-17782)
Reported by: lefoyer
Patches:
     issue19213_strip_color_in_safe_asterisk-svn.patch uploaded by wdoekes (license 717)
Tested by: wdoekes, lefoyer

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=317102
By: Digium Subversion (svnbot) 2011-05-05 09:56:53

Repository: asterisk
Revision: 317103

_U  branches/1.6.2/
U   branches/1.6.2/contrib/scripts/safe_asterisk

------------------------------------------------------------------------
r317103 | lmadsen | 2011-05-05 09:56:53 -0500 (Thu, 05 May 2011) | 15 lines

Merged revisions 317102 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r317102 | lmadsen | 2011-05-05 10:54:46 -0400 (Thu, 05 May 2011) | 8 lines
 
 Disable console colourization inside safe_asterisk checks.
 
 (closes issue ASTERISK-17782)
 Reported by: lefoyer
 Patches:
       issue19213_strip_color_in_safe_asterisk-svn.patch uploaded by wdoekes (license 717)
 Tested by: wdoekes, lefoyer
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=317103
By: Digium Subversion (svnbot) 2011-05-05 10:04:25

Repository: asterisk
Revision: 317104

_U  branches/1.8/
U   branches/1.8/contrib/scripts/safe_asterisk

------------------------------------------------------------------------
r317104 | lmadsen | 2011-05-05 10:04:25 -0500 (Thu, 05 May 2011) | 15 lines

Merged revisions 317102 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r317102 | lmadsen | 2011-05-05 10:54:46 -0400 (Thu, 05 May 2011) | 8 lines
 
 Disable console colourization inside safe_asterisk checks.
 
 (closes issue ASTERISK-17782)
 Reported by: lefoyer
 Patches:
       issue19213_strip_color_in_safe_asterisk-svn.patch uploaded by wdoekes (license 717)
 Tested by: wdoekes, lefoyer
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=317104
By: Digium Subversion (svnbot) 2011-05-05 10:07:00

Repository: asterisk
Revision: 317105

_U  trunk/
U   trunk/contrib/scripts/safe_asterisk

------------------------------------------------------------------------
r317105 | lmadsen | 2011-05-05 10:07:00 -0500 (Thu, 05 May 2011) | 22 lines

Merged revisions 317104 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r317104 | lmadsen | 2011-05-05 11:04:24 -0400 (Thu, 05 May 2011) | 15 lines
 
 Merged revisions 317102 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r317102 | lmadsen | 2011-05-05 10:54:46 -0400 (Thu, 05 May 2011) | 8 lines
   
   Disable console colourization inside safe_asterisk checks.
   
   (closes issue ASTERISK-17782)
   Reported by: lefoyer
   Patches:
         issue19213_strip_color_in_safe_asterisk-svn.patch uploaded by wdoekes (license 717)
   Tested by: wdoekes, lefoyer
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=317105