Summary:	ASTERISK-17793: [patch] sip_set_rtp_peer sometimes returns too early
Reporter:	Steve Davies (one47)	Labels:
Date Opened:	2011-05-04 04:45:06	Date Closed:	2011-05-09 12:13:02
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/General
Versions:	1.6.2.18	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) sip_set_rtp_peer.patch
Description:	sip_set_rtp_peer(...) has 2 common purposes. One to set a direct-media path, and one to RESET the media path to asterisk directly. The former is prevented if we are in an "early-media" phase, and have no bridge to set the media path to, but the code that prevents this also prevents a bridge that is being torn-down from RESETing the meida path to Asterisk. ****** ADDITIONAL INFORMATION ****** The reason I patched this was that if a call is "Redirect"ed back into the dialplan using AMI, and the call was set-up with a directmedia RTP path, the call to sip_set_rtp_peer(...) to revert the audio path to asterisk was failing. The attached patch causes the request to RESET the media path to always be allowed. I believe this may also fix the issues mentioned in a comment block in chan_sip.c:sip_fixup() where sip_set_rtp_peer() is called.
Comments:	By: Digium Subversion (svnbot) 2011-05-09 11:51:46 Repository: asterisk Revision: 318230 U   branches/1.6.2/channels/chan_sip.c ------------------------------------------------------------------------ r318230 | dvossel | 2011-05-09 11:51:46 -0500 (Mon, 09 May 2011) | 7 lines Fixes cases where sip_set_rtp_peer can return too early during media path reset. (closes issue ASTERISK-17793) Reported by: one47 Patches:      sip_set_rtp_peer.patch uploaded by one47 (license 23) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=318230 By: Digium Subversion (svnbot) 2011-05-09 12:09:57 Repository: asterisk Revision: 318233 _U  branches/1.8/ U   branches/1.8/channels/chan_sip.c ------------------------------------------------------------------------ r318233 | dvossel | 2011-05-09 12:09:56 -0500 (Mon, 09 May 2011) | 14 lines Merged revisions 318230 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ........  r318230 | dvossel | 2011-05-09 11:51:45 -0500 (Mon, 09 May 2011) | 7 lines    Fixes cases where sip_set_rtp_peer can return too early during media path reset.    (closes issue ASTERISK-17793)  Reported by: one47  Patches:        sip_set_rtp_peer.patch uploaded by one47 (license 23) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=318233 By: Digium Subversion (svnbot) 2011-05-09 12:13:02 Repository: asterisk Revision: 318234 _U  trunk/ U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r318234 | dvossel | 2011-05-09 12:13:01 -0500 (Mon, 09 May 2011) | 21 lines Merged revisions 318233 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................  r318233 | dvossel | 2011-05-09 12:09:55 -0500 (Mon, 09 May 2011) | 14 lines    Merged revisions 318230 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.6.2    ........    r318230 | dvossel | 2011-05-09 11:51:45 -0500 (Mon, 09 May 2011) | 7 lines        Fixes cases where sip_set_rtp_peer can return too early during media path reset.        (closes issue ASTERISK-17793)    Reported by: one47    Patches:          sip_set_rtp_peer.patch uploaded by one47 (license 23)  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=318234