[Home]

Summary:ASTERISK-17813: [patch] No inband progress on PRI_EVENT_RINGING even if inband flag set
Reporter:Cristian Dimache (cristiandimache)Labels:
Date Opened:2011-05-05 15:38:09Date Closed:2011-05-09 12:00:08
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue19246_v1.8.patch
( 1) pri_debug.txt
( 2) sig_pri_inband.diff
Description:My ISDN-PRI provider sends a ALERTING with "Inband information or appropriate pattern now available", but Asterisk only generates and passes the ring to the SIP extension, not the inband message.
Unfortunately, the inband message is not an actual RING, but a prompt that says the number is not in service. So, the SIP receives two rings and then a hangup, confusing the agent using the SIP extension.

****** ADDITIONAL INFORMATION ******

Problem appears to be in channels\sig_pri.c - i notice that on the PRI_EVENT_PROGRESS a voice path is brought up, but it isn't on a PRI_EVENT_RINGING with inband progress. So, my crude ideea of a patch is to duplicate the code on the PROGRESS in the RINGING. Solved my problem, but I don't know how clean the code is - I understand half of it :)
Comments:By: Richard Mudgett (rmudgett) 2011-05-05 17:55:27

Could you attach a libpri debug capture of the Q.931 messages to show what the network is sending?

pri set debug on span x
By: Cristian Dimache (cristiandimache) 2011-05-06 01:58:21

I have attached pri_debug.txt - this is after the patch was applied, but I don't think it makes much differentce. Also, sorry for the bad category of the bug, it should be chan_dahdi.

I do have another provider that handles the call setup well: SETUP - PROCEEDING - PROGRESS - ALERTING - DISCONNECT. So maybe we can do a per-span configuration entry for using the inband of ALERTING or not?
By: Richard Mudgett (rmudgett) 2011-05-06 12:21:27

The issue19246_v1.8.patch adds some missing tests for the progress.  It applies to the v1.8 SVN branch.
By: Cristian Dimache (cristiandimache) 2011-05-08 10:39:39

Patch issue19246_v1.8.patch works.
By: Digium Subversion (svnbot) 2011-05-09 11:57:21

Repository: asterisk
Revision: 318231

U   branches/1.8/channels/sig_pri.c

------------------------------------------------------------------------
r318231 | rmudgett | 2011-05-09 11:57:19 -0500 (Mon, 09 May 2011) | 41 lines

Don't get early media for ISDN on outgoing calls.

It looks to be a long-standing misinterpretation of the progress indicator
ie values:
1 - Call is not end-to-end ISDN; further call progress information may be
available in-band.
8 - In-band information or an appropriate pattern is now available.

Only value 8 is handled by chan_dahdi/sig_pri.  The 1 value is not handled
as early media probably because the meaning of the second half of it's
description was overlooked.

* Test to see if either PRI_PROG_CALL_NOT_E2E_ISDN(1) or
PRI_PROG_INBAND_AVAILABLE(8) bits are set to open the media path.

(closes issue ASTERISK-17459)
Reported by: isrl
Patches:
     issue18868_19246_v1.8.patch uploaded by rmudgett (license 664)
Tested by: satish_lx

..........

No inband progress on PRI_EVENT_RINGING even if inband flag set.

My ISDN-PRI provider sends an ALERTING with "Inband information or
appropriate pattern now available", but Asterisk only generates and passes
the RING to the SIP extension, not the inband message.  Unfortunately, the
inband message is not a ringback tone but a prompt that says the number is
not in service.  The SIP extension then hears two rings and the call is
hungup which confuses the caller.

* Post an AST_CONTROL_PROGRESS as well as opening the media path if inband
audio is indicated with an ALERTING message.

(closes issue ASTERISK-17813)
Reported by: cristiandimache
Patches:
     issue19246_v1.8.patch uploaded by rmudgett (license 664)
Tested by: cristiandimache

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=318231
By: Digium Subversion (svnbot) 2011-05-09 12:00:08

Repository: asterisk
Revision: 318232

_U  trunk/
U   trunk/channels/sig_pri.c

------------------------------------------------------------------------
r318232 | rmudgett | 2011-05-09 12:00:06 -0500 (Mon, 09 May 2011) | 48 lines

Merged revisions 318231 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r318231 | rmudgett | 2011-05-09 11:57:18 -0500 (Mon, 09 May 2011) | 41 lines
 
 Don't get early media for ISDN on outgoing calls.
 
 It looks to be a long-standing misinterpretation of the progress indicator
 ie values:
 1 - Call is not end-to-end ISDN; further call progress information may be
 available in-band.
 8 - In-band information or an appropriate pattern is now available.
 
 Only value 8 is handled by chan_dahdi/sig_pri.  The 1 value is not handled
 as early media probably because the meaning of the second half of it's
 description was overlooked.
 
 * Test to see if either PRI_PROG_CALL_NOT_E2E_ISDN(1) or
 PRI_PROG_INBAND_AVAILABLE(8) bits are set to open the media path.
 
 (closes issue ASTERISK-17459)
 Reported by: isrl
 Patches:
       issue18868_19246_v1.8.patch uploaded by rmudgett (license 664)
 Tested by: satish_lx
 
 ..........
 
 No inband progress on PRI_EVENT_RINGING even if inband flag set.
 
 My ISDN-PRI provider sends an ALERTING with "Inband information or
 appropriate pattern now available", but Asterisk only generates and passes
 the RING to the SIP extension, not the inband message.  Unfortunately, the
 inband message is not a ringback tone but a prompt that says the number is
 not in service.  The SIP extension then hears two rings and the call is
 hungup which confuses the caller.
 
 * Post an AST_CONTROL_PROGRESS as well as opening the media path if inband
 audio is indicated with an ALERTING message.
 
 (closes issue ASTERISK-17813)
 Reported by: cristiandimache
 Patches:
       issue19246_v1.8.patch uploaded by rmudgett (license 664)
 Tested by: cristiandimache
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=318232