Summary:	ASTERISK-17839: [patch] app_privacy arguments reference invalid "options" option, interferes with "context" option
Reporter:	Malcolm Davenport (mdavenport)	Labels:
Date Opened:	2011-05-11 09:50:08	Date Closed:	2011-05-27 17:09:05
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_privacy
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) privacymanager.diff
Description:	app_privacy has an "options" application argument defined, but it's not actually used.  This interferes with the use of the "context" option, since, as documented, you can't use the "context" option. Attaching patch to remove "options" option, since there's nothing in app_privacy.c that references it otherwise.
Comments:	By: Leif Madsen (lmadsen) 2011-05-11 14:21:54 Nice patch for trunk, but we can't do this for 1.8 as that could cause backwards incompatibility. We'll have to create a patch to update the documentation for 1.8. By: Malcolm Davenport (mdavenport) 2011-05-11 15:41:57 It'd only be an incompatibility for anyone that bothered to read the source; everyone else will find it as a bug fix for a feature that wouldn't have worked as documented since it was added in 1.6.1. By: Leif Madsen (lmadsen) 2011-05-27 15:45:07 I disagree. If anyone else had actually figured out the order of the fields and wrote dialplan matching what the code actually does, then we break their dialplan. We need to update the documentation for 1.8 to match the code, and in trunk we can update the code to do what we feel is right, update CHANGES and UPGRADE.txt, then make the documentation match what is actually there. By: Digium Subversion (svnbot) 2011-05-27 16:31:26 Repository: asterisk Revision: 321330 U   branches/1.8/apps/app_privacy.c ------------------------------------------------------------------------ r321330 | rmudgett | 2011-05-27 16:31:25 -0500 (Fri, 27 May 2011) | 8 lines The app_privacy args have undocumented "options" position, interferes with "context" position. * Add documention for unused "options" position to match existing code. The trunk(v1.10) version will remove the unused options position. (closes issue ASTERISK-17839) Reported by: mdavenport ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=321330 By: Digium Subversion (svnbot) 2011-05-27 16:34:05 Repository: asterisk Revision: 321331 _U  trunk/ U   trunk/CHANGES U   trunk/apps/app_privacy.c ------------------------------------------------------------------------ r321331 | rmudgett | 2011-05-27 16:34:04 -0500 (Fri, 27 May 2011) | 15 lines Merged revisions 321330 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........  r321330 | rmudgett | 2011-05-27 16:31:25 -0500 (Fri, 27 May 2011) | 8 lines    The app_privacy args have undocumented "options" position, interferes with "context" position.    * Add documention for unused "options" position to match existing code.  The trunk(v1.10) version will remove the unused options position.    (closes issue ASTERISK-17839)  Reported by: mdavenport ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=321331 By: Digium Subversion (svnbot) 2011-05-27 17:06:44 Repository: asterisk Revision: 321337 U   branches/1.8/apps/app_privacy.c ------------------------------------------------------------------------ r321337 | rmudgett | 2011-05-27 17:06:44 -0500 (Fri, 27 May 2011) | 7 lines The app_privacy args have undocumented "options" position, interferes with "context" position. * Add documention for unused "options" position to match existing code. (closes issue ASTERISK-17839) Reported by: mdavenport ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=321337 By: Digium Subversion (svnbot) 2011-05-27 17:09:04 Repository: asterisk Revision: 321338 _U  trunk/ U   trunk/CHANGES U   trunk/UPGRADE.txt U   trunk/apps/app_privacy.c ------------------------------------------------------------------------ r321338 | rmudgett | 2011-05-27 17:09:04 -0500 (Fri, 27 May 2011) | 16 lines Merged revisions 321337 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 Also revert -r321331 and -r321332. ........  r321337 | rmudgett | 2011-05-27 17:06:43 -0500 (Fri, 27 May 2011) | 7 lines    The app_privacy args have undocumented "options" position, interferes with "context" position.    * Add documention for unused "options" position to match existing code.    (closes issue ASTERISK-17839)  Reported by: mdavenport ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=321338