[Home]

Summary:ASTERISK-17843: change BOOL to PBoolean
Reporter:Jose P. Espinal (khratos)Labels:
Date Opened:2011-05-11 23:22:20Date Closed:2011-06-07 14:05:05
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_h323
Versions:1.8.4 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Hello,

As it was informed in the H323plus (former OpenH323) mailing list:
http://lists.packetizer.com/pipermail/h323plus/2007-November/000756.html

BOOL was changed to PBoolean, and their reasons were: "so that PBoolean could be defined as the ANSI standard bool type and we get a whole pile of beneficial compile time checks"

If we change BOOL references to PBoolean in 'channels/h323/ast_h323.cxx' and 'channels/h323/ast_h323.h' then we can successfully use compile against the latest versions of PTLib (former PWLib) and H323plus.

I've tested this change before in Asterisk 1.4, and now in Asterisk 1.8

****** ADDITIONAL INFORMATION ******

At least in 1.4, chan_h323 (using the latest versions of H323plus) behave very stable, and once worked even when ooh323 failed (Interconnecting with a strange Cisco or Nortel stuff of my Telco).

In order to compile without problems, the SlackBuild I wrote changes a bit the configure script:

----- before running configure, in Asterisk source directory, I make this -----

###########################
# Attempting to force the configure script to use our installed
# version of OpenH323
###########################
OPENH323_VERSION=`grep "OPENH323_VERSION" /usr/include/openh323/openh323buildopts.h | cut -f3 -d ' ' | sed -e 's/"//g'`

OPENH323_MAJOR_VERSION=`echo ${OPENH323_VERSION} | cut -f1 -d.`
OPENH323_MINOR_VERSION=`echo ${OPENH323_VERSION} | cut -f2 -d.`
OPENH323_BUILD_NUMBER=`echo ${OPENH323_VERSION} | cut -f3 -d.`

let OPENH323_VER=${OPENH323_MAJOR_VERSION}*10000+${OPENH323_MINOR_VERSION}*100+${OPENH323_BUILD_NUMBER}

sed -i.original 's|let OPENH323_MAX=1.*$|let OPENH323_MAX=\${OPENH323_MAJOR_VERSION}*10000+${OPENH323_MINOR_VERSION}*100+${OPENH323_BUILD_NUMBER}|' configure

---------- END ---------

Basically, I just change the 'OPENH323_MAX' variable to accept the value detected for my installed version.


Comments:By: Jose P. Espinal (khratos) 2011-05-11 23:30:59

patch -p0 < chan_h323.patch

By: Jose P. Espinal (khratos) 2011-05-12 11:05:37

http://packages.eslackware.com/contrib/chan_h323.patch

By: Gregory Hinton Nietsky (irroot) 2011-05-13 00:00:24

see ASTERISK-15444

By: Leif Madsen (lmadsen) 2011-05-16 14:24:13

Closed per the note by me on ASTERISK-15444