Summary: | ASTERISK-17861: [regression] Big Endian breakage (regression since gcc 4.6 fix) | ||
Reporter: | Tzafrir Cohen (tzafrir) | Labels: | |
Date Opened: | 2011-05-16 04:05:36 | Date Closed: | 2011-05-16 09:29:08 |
Priority: | Blocker | Regression? | Yes |
Status: | Closed/Complete | Components: | General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | (Filed under General: I noticed one simple case in formats/format_wav.c from a build log, but did not get to try this on a test build system. Will update summary and add a patch later on) r316265 removed many cases of unused variables, reported by gcc 4.6. Sadly It also, at least in one case, broke building of big-endian systems. Fix in this case should be simple (move decleration of tmp into the ifdef above rather than remove it). (The version number might confuse: the built code is 1.8.4 with that specific fix applied on top of it. 1.8.4 does not include that fix) ****** ADDITIONAL INFORMATION ****** Build log from a Debian powerpc buildd: powerpc-linux-gnu-gcc -o format_sln16.o -c format_sln16.c -MD -MT format_sln16.o -MF .format_sln16.o.d -MP -pthread -I/build/buildd-asterisk_1.8.4-1-powerpc-r6gjEz/asterisk-1.8.4/include -g -O2 -I/usr/include/libxml2 -pipe -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -g3 -O2 -fPIC -DAST_MODULE=\"format_sln16\" /build/buildd-asterisk_1.8.4-1-powerpc-r6gjEz/asterisk-1.8.4/build_tools/make_linker_version_script format_sln16 "" "/build/buildd-asterisk_1.8.4-1-powerpc-r6gjEz/asterisk-1.8.4" powerpc-linux-gnu-gcc -o format_sln16.so -pthread -shared -Wl,--version-script,format_sln16.exports,--warn-common format_sln16.o powerpc-linux-gnu-gcc -o format_vox.o -c format_vox.c -MD -MT format_vox.o -MF .format_vox.o.d -MP -pthread -I/build/buildd-asterisk_1.8.4-1-powerpc-r6gjEz/asterisk-1.8.4/include -g -O2 -I/usr/include/libxml2 -pipe -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -g3 -O2 -fPIC -DAST_MODULE=\"format_vox\" /build/buildd-asterisk_1.8.4-1-powerpc-r6gjEz/asterisk-1.8.4/build_tools/make_linker_version_script format_vox "" "/build/buildd-asterisk_1.8.4-1-powerpc-r6gjEz/asterisk-1.8.4" powerpc-linux-gnu-gcc -o format_vox.so -pthread -shared -Wl,--version-script,format_vox.exports,--warn-common format_vox.o powerpc-linux-gnu-gcc -o format_wav.o -c format_wav.c -MD -MT format_wav.o -MF .format_wav.o.d -MP -pthread -I/build/buildd-asterisk_1.8.4-1-powerpc-r6gjEz/asterisk-1.8.4/include -g -O2 -I/usr/include/libxml2 -pipe -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -g3 -O2 -fPIC -DAST_MODULE=\"format_wav\" format_wav.c: In function 'wav_read': format_wav.c:391:2: error: 'tmp' undeclared (first use in this function) format_wav.c:391:2: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [format_wav.o] Error 1 make[2]: Leaving directory `/build/buildd-asterisk_1.8.4-1-powerpc-r6gjEz/asterisk-1.8.4/formats' make[1]: *** [formats] Error 2 make[1]: Leaving directory `/build/buildd-asterisk_1.8.4-1-powerpc-r6gjEz/asterisk-1.8.4' make: *** [build-arch-stamp] Error 2 | ||
Comments: | By: Digium Subversion (svnbot) 2011-05-16 09:26:37 Repository: asterisk Revision: 319083 U branches/1.8/formats/format_wav.c ------------------------------------------------------------------------ r319083 | dvossel | 2011-05-16 09:26:34 -0500 (Mon, 16 May 2011) | 5 lines Fixes Big Endian build issue. (closes issue ASTERISK-17861) Reported by: tzafrir ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=319083 By: Digium Subversion (svnbot) 2011-05-16 09:29:07 Repository: asterisk Revision: 319084 _U trunk/ U trunk/formats/format_wav.c ------------------------------------------------------------------------ r319084 | dvossel | 2011-05-16 09:29:07 -0500 (Mon, 16 May 2011) | 12 lines Merged revisions 319083 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........ r319083 | dvossel | 2011-05-16 09:26:33 -0500 (Mon, 16 May 2011) | 5 lines Fixes Big Endian build issue. (closes issue ASTERISK-17861) Reported by: tzafrir ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=319084 |