[Home]

Summary:ASTERISK-17907: [patch] chanspy enforced mode lacks a channel_unlock
Reporter:Walter Doekes (wdoekes)Labels:
Date Opened:2011-05-23 07:49:09Date Closed:2011-05-23 09:48:54
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_chanspy
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue19348_chanspy_missing_channel_unlock.patch
Description:Hi,

in https://issues.asterisk.org/view.php?id=18647#133039 I reported that I couldn't dial out if someone was spying on the channel.

It seems that both 1.6.2.17.3 (probably 18 too) and 1.6.2-svn work just fine, except if one is using the 'e' OPTION_ENFORCED mode.

****** STEPS TO REPRODUCE ******

If the following executes in app_chanspy, we get a deadlock. This happens if the channel searched is not in the enforced list.

if (!ienf) {
 continue;
}

Cause: a missing ast_channel_unlock(peer);

****** ADDITIONAL INFORMATION ******

The attached patch fixes the issue. I haven't checked whether other versions are affected.

Regards,
Walter Doekes
OSSO B.V.
Comments:By: Digium Subversion (svnbot) 2011-05-23 09:46:18

Repository: asterisk
Revision: 320506

U   branches/1.6.2/apps/app_chanspy.c

------------------------------------------------------------------------
r320506 | dvossel | 2011-05-23 09:46:18 -0500 (Mon, 23 May 2011) | 8 lines

Fixes chanspy enforced mode lacking a channel_unlock.

(closes issue ASTERISK-17907)
Reported by: wdoekes
Patches:
     issue19348_chanspy_missing_channel_unlock.patch uploaded by wdoekes (license 717)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=320506
By: Digium Subversion (svnbot) 2011-05-23 09:48:54

Repository: asterisk
Revision: 320507

_U  branches/1.8/

------------------------------------------------------------------------
r320507 | dvossel | 2011-05-23 09:48:53 -0500 (Mon, 23 May 2011) | 13 lines

Blocked revisions 320506 via svnmerge

........
 r320506 | dvossel | 2011-05-23 09:46:17 -0500 (Mon, 23 May 2011) | 8 lines
 
 Fixes chanspy enforced mode lacking a channel_unlock.
 
 (closes issue ASTERISK-17907)
 Reported by: wdoekes
 Patches:
       issue19348_chanspy_missing_channel_unlock.patch uploaded by wdoekes (license 717)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=320507